Skip to content

Warning about active blue mapping in colorin #21487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jenshannoschwalm wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −0
Open

Warning about active blue mapping in colorin #21487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/iop/colorin.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2037,6 +2037,20 @@ static void update_profile_list(dt_iop_module_t *self)
}
}

static void _preview_pipe_finished_callback(gpointer instance, dt_iop_module_t *self)
{
if(!self->gui_data) return;
dt_iop_colorin_params_t *p = self->params;
const gboolean on = p->blue_mapping;
dt_iop_set_module_trouble_message
(self,
on ? _("blue mapping") : NULL,
on ? _("the blue mapping mode has been deprecated since very long and has been removed.\n"
"reset to defaults or switch to any colorin profile and check results. minimal\n"
"visual differences might be possible.") : NULL,
on ? "blue mode detected in colorin module" : NULL);
}

void gui_init(dt_iop_module_t *self)
{
// pthread_mutex_lock(&darktable.plugin_threadsafe);
Expand Down Expand Up @@ -2071,6 +2085,7 @@ void gui_init(dt_iop_module_t *self)
g->clipping_combobox = dt_bauhaus_combobox_from_params(self, "normalize");
gtk_widget_set_tooltip_text(g->clipping_combobox,
_("confine Lab values to gamut of RGB color space"));
DT_CONTROL_SIGNAL_HANDLE(DT_SIGNAL_DEVELOP_PREVIEW_PIPE_FINISHED, _preview_pipe_finished_callback);
}

void gui_cleanup(dt_iop_module_t *self)
Expand Down
Loading