server: match vanilla shulker box drop behaviour - #1365
Conversation
HashimTheArab
changed the title
|
@HashimTheArab shulker should be droped even if explosion block drop chance is 0 |
| return newBreakInfo(2, alwaysHarvestable, pickaxeEffective, oneOf(s)) | ||
| } | ||
|
|
||
| // CreativeDrops returns the drops produced when a creative player breaks the shulker box. Filled shulker boxes retain |
There was a problem hiding this comment.
Why can't this be done with a break handler
There was a problem hiding this comment.
pretty sure it's to match bedrock natively in dragonfly
There was a problem hiding this comment.
because it bypassed HandleBlockBreak
There was a problem hiding this comment.
This should be inside of BreakInfo instead of being its own thing.
because it bypassed HandleBlockBreak
Then we should also switch over all the container blocks that drop their content on break. So don't call this CreativeDrops, and make explosions drop those items too instead of what's happening under here.
There was a problem hiding this comment.
We'll keep this pr consistent with the existing behavior then and PR a separate fix for all the blocks
HashimTheArab
left a comment
HashimTheArab
left a comment
There was a problem hiding this comment.
Restored the PR to the original break-handler implementation; the generalized drop pipeline will follow separately.
4 participants
This pr fixes shulkerbox breaking behavior.