Skip to content

server: match vanilla shulker box drop behaviour #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FDUTCH wants to merge 4 commits into
base: master
Choose a base branch
from
+10 −1
Open

server: match vanilla shulker box drop behaviour #1365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d9c703
match vanilla behavior
FDUTCH Aug 1, 2026
2ffb5d8
Preserve shulker drops in block break handlers
HashimTheArab Aug 1, 2026
e89d0f6
server/block: always drop exploded shulker boxes
HashimTheArab Aug 1, 2026
ed4929c
Restore shulker break handler implementation
HashimTheArab Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion server/block/shulker_box.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,15 @@ func shulkerPushDelta(facing cube.Face, shulkerBBox, entityBBox cube.BBox) (delt
}

func (s ShulkerBox) BreakInfo() BreakInfo {
return newBreakInfo(2, alwaysHarvestable, pickaxeEffective, oneOf(s))
return newBreakInfo(2, alwaysHarvestable, pickaxeEffective,
func(_ item.Tool, _ []item.Enchantment) []item.Stack { return nil }).
// shulker box always has a drop, except when player in creative breaks empty box.
withBreakHandler(func(pos cube.Pos, tx *world.Tx, u item.User) {
if u != nil && u.GameMode().CreativeInventory() && s.Inventory(tx, pos).Empty() {
return
}
dropItem(tx, item.NewStack(s, 1), pos.Vec3Centre())
})
}

func (s ShulkerBox) MaxCount() int {
Expand Down
1 change: 1 addition & 0 deletions server/item/item.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ type User interface {
UsingItem() bool
ReleaseItem()
UseItem()
GameMode() world.GameMode
}

// Carrier represents an entity that is able to carry an item.
Expand Down