Skip to content

Avoid draining fresh virtio-serial agent handshakes#377

Draft
motatoes wants to merge 1 commit into
mainfrom
fix/qemu-virtio-serial-no-preaccept-drain
Draft

Avoid draining fresh virtio-serial agent handshakes#377
motatoes wants to merge 1 commit into
mainfrom
fix/qemu-virtio-serial-no-preaccept-drain

Conversation

@motatoes

Copy link
Copy Markdown
Contributor

Summary

  • stop discarding pending virtio-serial bytes immediately before accepting the next agent gRPC connection
  • avoids dropping the fresh HTTP/2 client preface after QEMU golden restore

Validation

  • Reproduced failure with drain enabled on dev AWS QEMU golden restore: VM resumed in ~336ms, then agent ping timed out after 30s.
  • Removed only the pre-accept drain call, rebuilt golden, and sandbox creation hot-booted successfully.
  • Re-enabled drain only, rebuilt golden, and reproduced the 30s timeout again.
  • Restored no-drain build, rebuilt golden, and verified sandbox creation succeeds again.
  • Ran: GOOS=linux GOARCH=amd64 go test ./cmd/agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant