Skip to content

Avoid draining fresh virtio-serial agent handshakes #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
motatoes wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Avoid draining fresh virtio-serial agent handshakes #377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cmd/agent/listen_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,8 @@ func (l *virtioSerialListener) Accept() (net.Conn, error) {
// bytes (GOAWAY frames, partial HTTP/2 frames). If we hand these to
// the new gRPC session, it gets a protocol error and closes immediately.
if instrumentVirtioSerial {
log.Printf("virtio-serial: Accept iter: active=false, draining stale...")
log.Printf("virtio-serial: Accept iter: active=false, waiting for fresh data...")
}
drainStaleData(l.f)

// Wait for the host to connect (port becomes readable with fresh data)
if !waitForReadable(l.f, 500*time.Millisecond) {
Expand Down