Repository navigation
Link the data files of zweedse voorouders and data-visualization in the feedback - #65
Merged
Merged
Conversation
This was referenced Oct 19, 2026
TomNaessens
marked this pull request as ready for review
October 19, 2026 19:26
bmesuere
approved these changes
Oct 19, 2026
The suite read dataN.txt from workdir/ without declaring it, so TESTed added no link and students couldn't open the data their tests used. Each context now declares its file as input_files (copied from evaluation/data/, linked to description/media/data/), and the generator writes the same shape. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TomNaessens
force-pushed
the
bug/zweedse-voorouders-file-links
branch
from
October 19, 2026 20:25
fafd07f to
46db236
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #60: the
zweedse voorouderssuite calledfamilyMembers("dataN.txt")without declaring the file, so TESTed added no link to it in the feedback and students couldn't open the data their tests used.data-visualizationhad the same gap with its CSV files.input_files(path: "dataN.txt",content: !path "data/dataN.txt"). The 50 data files moved fromworkdir/toevaluation/data/(where TESTed copies input files from), with a copy indescription/media/data/(where the feedback link points).preparation/generator.jswrites the same shape, so a regeneration keeps the links. The data itself is unchanged.workdir/toevaluation/(the copies indescription/media/were already there and identical).How it works in TESTed (universal-judge master 8960b3e6):
input_filescopies each file fromevaluation/into that testcase's run and adds{"location": "href", "content": "media/<file>"}to itsclose-context; Dodona turns the file name in the testcase into a link that opens the file fromdescription/media/.The other exercises were checked for the same gap:
mad libs,echoandinput-through-promptread no files, and the Pythonfilesexample already declares and linksunsorted.txt. The Bashline-countexample in #54 declared its files but had nodescription/media/copy, so its links would have 404'd; fixed there.Rebased onto #63 (merged), which moved
tested/data-visualizationtotested/python/data-visualization; the change now applies there, with the same suite.Part of https://github.com/dodona-edu/dodona/issues/8846.
Manual testing instructions
data/exercises/) and reprocess it; sign in as zeus (http://dodona.localhost:3000/dev_sign_in/1).tested/javascript/zweedse voorouders) and submit itssolution/solution.js: correct, and in the first contextdata1.txtinlet relations1 = familyMembers("data1.txt")is a link.data1.txt.solution/solution.py: each tab's testcases link the CSV they read (e.g.pokemon.csv).Verification
dodona-authoring verify skill, ghcr.io/dodona-edu/dodona-tested, universal-judge master; "en"/"nl" are runs the way Dodona does them:
Feedback excerpt (zweedse voorouders, first context):
{"data": {"files": {"data1.txt": {"location": "href", "content": "media/data/data1.txt"}}}, "command": "close-context"}Generator: run on a scratch copy, its output has the same structure line for line as the committed suite (756 structural lines identical, 1712 lines after masking names and values).
Local Dodona (origin/main 5ecd1fcef, TESTed judge from universal-judge master, this branch as the repository remote): the reference solution was accepted; the
data1.txtlink resolves to/en/submissions/1/media/data/data1.txt?token=..., and the returned file is byte-identical todescription/media/data/data1.txt.🤖 Generated with Claude Code