[tests] Improve new BasicAuthWorksWhenBearerIsAdvertisedFirst test. by rolfbjarne · Pull Request #25503 · dotnet/macios

rolfbjarne · 2026-05-22T07:29:29Z

Remove unused 'using System.Net.Http.Headers' directive.
Track request counts server-side and assert that at least one
unauthenticated request was received before the authenticated retry,
ensuring the test validates the actual challenge/fallback flow.

- Remove unused 'using System.Net.Http.Headers' directive. - Track request counts server-side and assert that at least one unauthenticated request was received before the authenticated retry, ensuring the test validates the actual challenge/fallback flow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR refines the NSUrlSessionHandler authentication regression test to better validate the Basic-auth fallback behavior when the server advertises Bearer before Basic, and removes an unused import.

Changes:

Removed an unused using System.Net.Http.Headers; directive.
Added server-side request counters and assertions intended to verify that the client performs an unauthenticated request before retrying with Basic authentication.

Instead of just counting unauthenticated and authenticated requests, track the index of each to assert that the unauthenticated (401) request arrived before the authenticated retry, proving the correct ordering. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ment

vs-mobiletools-engineering-service2 · 2026-05-26T06:50:15Z

✅ [PR Build #f16a2fb] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: f16a2fb04d2b6647fffb829336986b4d07e50a17 [PR build]

vs-mobiletools-engineering-service2 · 2026-05-26T06:51:51Z

✅ [PR Build #f16a2fb] Build passed (Build packages) ✅

Pipeline on Agent
Hash: f16a2fb04d2b6647fffb829336986b4d07e50a17 [PR build]

vs-mobiletools-engineering-service2 · 2026-05-26T07:03:29Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: f16a2fb04d2b6647fffb829336986b4d07e50a17 [PR build]

vs-mobiletools-engineering-service2 · 2026-05-26T07:11:33Z

✅ [PR Build #f16a2fb] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: f16a2fb04d2b6647fffb829336986b4d07e50a17 [PR build]

vs-mobiletools-engineering-service2 · 2026-05-26T08:29:32Z

🔥 [CI Build #f16a2fb] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 182 tests passed.

Failures

❌ monotouch tests (MacCatalyst)

1 tests failed, 19 tests passed.

Failed tests

monotouch-test/Mac Catalyst/Release (trimmable static registrar, NativeAOT, ARM64): Failed (Test run crashed (exit code: 137).
Test run crashed)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 20 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 18 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: f16a2fb04d2b6647fffb829336986b4d07e50a17 [PR build]

rolfbjarne requested a review from Copilot May 22, 2026 07:29

rolfbjarne added the copilot label May 22, 2026

Copilot started reviewing on behalf of rolfbjarne May 22, 2026 07:30 View session

Copilot AI reviewed May 22, 2026

View reviewed changes

Comment thread tests/monotouch-test/System.Net.Http/NSUrlSessionHandlerTest.cs Outdated

This comment has been minimized.

Sign in to view

rolfbjarne and others added 2 commits May 25, 2026 09:43

Merge remote-tracking branch 'origin/main' into dev/rolf/test-improve…

86f85bf

…ment

This comment has been minimized.

Sign in to view

rolfbjarne marked this pull request as ready for review May 25, 2026 16:33

rolfbjarne enabled auto-merge (squash) May 25, 2026 16:33

This comment has been minimized.

Sign in to view

dalexsoto approved these changes May 26, 2026

View reviewed changes

Merge branch 'main' into dev/rolf/test-improvement

f16a2fb

This comment has been minimized.

Sign in to view

Conversation

rolfbjarne commented May 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 26, 2026

✅ [PR Build #f16a2fb] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 26, 2026

✅ [PR Build #f16a2fb] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 26, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented May 26, 2026

✅ [PR Build #f16a2fb] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 26, 2026

🔥 [CI Build #f16a2fb] Test results 🔥

Test results

Failures

❌ monotouch tests (MacCatalyst)

Failed tests

Successes

macOS tests

Linux Build Verification

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants