Skip to content

[tests] Improve new BasicAuthWorksWhenBearerIsAdvertisedFirst test. #25503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 4 commits into from
May 27, 2026
+9 −1
Merged

[tests] Improve new BasicAuthWorksWhenBearerIsAdvertisedFirst test. #25503

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fecef63
[tests] Improve new BasicAuthWorksWhenBearerIsAdvertisedFirst test.
rolfbjarne May 21, 2026
e21e399
Track request ordering to properly validate challenge/fallback flow
rolfbjarne May 25, 2026
86f85bf
Merge remote-tracking branch 'origin/main' into dev/rolf/test-improve…
rolfbjarne May 25, 2026
f16a2fb
Merge branch 'main' into dev/rolf/test-improvement
rolfbjarne May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tests/monotouch-test/System.Net.Http/NSUrlSessionHandlerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
using System;
using System.Net;
using System.Net.Http;
using System.Net.Http.Headers;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -234,6 +233,9 @@ public void BasicAuthWorksWhenBearerIsAdvertisedFirst ()
var expectedBasicValue = Convert.ToBase64String (Encoding.UTF8.GetBytes ($"{username}:{password}"));

var serverReady = new SemaphoreSlim (0, 1);
int requestIndex = 0;
int firstUnauthenticatedIndex = -1;
int firstAuthenticatedIndex = -1;

var httpListener = StartListenerOnAvailablePort (out var listeningPort);
if (httpListener is null) {
Expand All @@ -250,14 +252,17 @@ public void BasicAuthWorksWhenBearerIsAdvertisedFirst ()
var response = context.Response;

var authHeader = request.Headers ["Authorization"];
var currentIndex = Interlocked.Increment (ref requestIndex);
if (authHeader is not null && authHeader == $"Basic {expectedBasicValue}") {
// Authenticated - return success
Interlocked.CompareExchange (ref firstAuthenticatedIndex, currentIndex, -1);
response.StatusCode = 200;
var body = Encoding.UTF8.GetBytes ("authenticated");
response.ContentLength64 = body.Length;
response.OutputStream.Write (body, 0, body.Length);
} else {
// Return 401 with Bearer first, then Basic
Interlocked.CompareExchange (ref firstUnauthenticatedIndex, currentIndex, -1);
response.StatusCode = 401;
response.AddHeader ("WWW-Authenticate", "Bearer realm=\"test\", charset=\"UTF-8\"");
response.AppendHeader ("WWW-Authenticate", "Basic realm=\"test\", charset=\"UTF-8\"");
Expand Down Expand Up @@ -291,6 +296,9 @@ public void BasicAuthWorksWhenBearerIsAdvertisedFirst ()
Assert.That (ex, Is.Null, $"Exception: {ex}");
Assert.That (statusCode, Is.EqualTo (HttpStatusCode.OK), "Expected 200 OK after Basic auth negotiation");
Assert.That (responseBody, Is.EqualTo ("authenticated"), "Response body");
Assert.That (firstUnauthenticatedIndex, Is.GreaterThan (0), "Server should have received an unauthenticated request");
Assert.That (firstAuthenticatedIndex, Is.GreaterThan (0), "Server should have received an authenticated request");
Assert.That (firstUnauthenticatedIndex, Is.LessThan (firstAuthenticatedIndex), "Unauthenticated request should have arrived before the authenticated retry");

if (serverTask.IsFaulted)
Assert.Fail ($"Server task failed: {serverTask.Exception}");
Expand Down
Loading