Fix JsonIgnoreCondition.WhenWritingNull doc#128127
Open
lilinus wants to merge 1 commit into
Open
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-text-json |
d95ce94 to
a28454e
Compare
This was referenced May 13, 2026
Open
| /// <summary> | ||
| /// If the value is <see langword="null"/>, the property is ignored during serialization. | ||
| /// This is applied only to reference-type properties and fields. | ||
| /// This is applied only to reference and nullable value-type properties and fields. |
Member
There was a problem hiding this comment.
Why not keep simple?
Suggested change
| /// This is applied only to reference and nullable value-type properties and fields. | |
| /// This is applied only to nullable type properties and fields. |
Contributor
Author
There was a problem hiding this comment.
Sounds good, unless it can be misinterpreted as not applied to non-nullable reference types in context. WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc only
It acutally applies to nullable value types too
Should I manually make PR to https://github.com/dotnet/docs ?