Skip to content

Fix JsonIgnoreCondition.WhenWritingNull doc #128127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lilinus wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Fix JsonIgnoreCondition.WhenWritingNull doc #128127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Text.Json/Common/JsonIgnoreCondition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public enum JsonIgnoreCondition
WhenWritingDefault = 2,
/// <summary>
/// If the value is <see langword="null"/>, the property is ignored during serialization.
/// This is applied only to reference-type properties and fields.
/// This is applied only to reference and nullable value-type properties and fields.
Copy link
Copy Markdown
Member

@eiriktsarpalis eiriktsarpalis May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep simple?

Suggested change
/// This is applied only to reference and nullable value-type properties and fields.
/// This is applied only to nullable type properties and fields.

Copy link
Copy Markdown
Contributor Author

@lilinus lilinus May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, unless it can be misinterpreted as not applied to non-nullable reference types in context. WDYT?

/// </summary>
WhenWritingNull = 3,
/// <summary>
Expand Down
Loading