ci: add peak RSS memory check to check-geometry-configs#1120
Open
wdconinc wants to merge 4 commits into
Open
Conversation
Wrap each checkGeometry invocation with /usr/bin/time -v to measure peak resident set size (RSS). The peak RSS is printed for every config on every run, providing a visible trend in CI logs. The job fails if any config exceeds MEMORY_LIMIT_KB (currently 4 GB), preventing silent growth of the geometry memory footprint. This is analogous to eic/containers#289 which caps compressed container image size: the limit is a hardcoded constant in the workflow file, so changing it requires a conscious, reviewable PR. The initial limit of 4 GB is deliberately generous. The first CI run will report actual peak RSS values for all configs; the limit will be tightened to baseline + ~20% headroom in a follow-up commit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a CI safeguard to prevent geometry memory footprint regressions by measuring per-detector peak RSS during the check-geometry-configs workflow and failing the job if a config exceeds a configured threshold.
Changes:
- Wraps each
checkGeometryinvocation with/usr/bin/time -vto capture peak RSS per geometry config. - Introduces a hardcoded
MEMORY_LIMIT_KBthreshold and fails the job when exceeded. - Aggregates per-config results into a single job exit code after iterating all configs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
Bot
added
the
topic: infrastructure
Contributor
Author
|
Fails as intended and error is prominent. |
wdconinc
moved this to In Review
in ePIC Review Board (auto-populated; changes will be discarded)
wdconinc
moved this from In Review
to Needs Review
in ePIC Review Board (auto-populated; changes will be discarded)
Contributor
Author
|
Sorry, this was filed from a fork, I just noticed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
Adds a peak RSS (resident set size) check to the
check-geometry-configsCI job. Each geometry config is loaded withcheckGeometrywrapped by/usr/bin/time -v; the peak RSS is printed for every config on every run, and the job fails if any config exceeds a hardcoded threshold (MEMORY_LIMIT_KB, initially 4 GB).This prevents silent growth of the geometry memory footprint, analogous to eic/containers#289 which caps compressed container image size. The limit is a hardcoded constant in the workflow file, so increasing it requires a conscious, reviewable PR.
The initial limit of 4 GB is deliberately generous — the first CI run on this PR will reveal actual peak RSS values for all configs, and the limit will be tightened to baseline + ~20% headroom in a follow-up commit.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply
Strategy defined by human; implementation by GitHub Copilot CLI, reviewed by human.