Skip to content

ci: add peak RSS memory check to check-geometry-configs #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wdconinc wants to merge 4 commits into
base: main
Choose a base branch
from
+14 −2
Open

ci: add peak RSS memory check to check-geometry-configs #1120

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1509dfa
ci: add peak RSS memory check to check-geometry-configs
wdconinc May 30, 2026
3f53eb3
fix: limit memory to 1.2 GB
wdconinc May 30, 2026
f80625c
fix: print RSS errors outside config logging group
wdconinc May 30, 2026
882dbf2
fix: bump memory limit to also fit bic_6layers
wdconinc May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/check-geometry-configs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,21 @@ jobs:
setup: install/bin/thisepic.sh
run: |
export DETECTOR_CACHE=/opt/detector/epic-main/share/epic
MEMORY_LIMIT_KB=1300000 # 1.3 GB – update this deliberately when geometry grows
IFS=, read -a configs <<< "${{inputs.detector_configs}}"
overall_rc=0
for config in ${configs[@]} ; do
echo "::group::${config}" ;
checkGeometry -c ${DETECTOR_PATH}/${config}.xml ;
echo "::endgroup::" ;
/usr/bin/time -v -o /tmp/time_${config}.txt \
checkGeometry -c ${DETECTOR_PATH}/${config}.xml
rc=$?
peak_rss_kb=$(grep "Maximum resident set size" /tmp/time_${config}.txt | awk '{print $NF}')
echo "Peak RSS for ${config}: ${peak_rss_kb} kB (limit: ${MEMORY_LIMIT_KB} kB)"
echo "::endgroup::"
if [ "${peak_rss_kb}" -gt "${MEMORY_LIMIT_KB}" ]; then
Comment thread
wdconinc marked this conversation as resolved.
echo "::error::Memory limit exceeded for ${config}: ${peak_rss_kb} kB > ${MEMORY_LIMIT_KB} kB"
overall_rc=1
fi
[ $rc -ne 0 ] && overall_rc=$rc
done
exit $overall_rc
Loading