Repository navigation
Build the tutorial against ember-source main - #294
Open
NullVoxPopuli-ai-agent wants to merge 2 commits into
Open
NullVoxPopuli-ai-agent wants to merge 2 commits into
NullVoxPopuli-ai-agent wants to merge 2 commits into
Conversation
runspired
pushed a commit
to warp-drive-data/warp-drive
that referenced
this pull request
Oct 26, 2026
With ember-source `main`, an app that imports `@warp-drive/legacy` gets this deprecation when the module loads: ``` `mapBy` from `@ember/object/computed` is deprecated. Use a getter with native array methods instead. ``` The cause is `Errors` in `warp-drive-packages/legacy/src/model/-private/errors.ts`. It applies the `mapBy` and `not` macros at class definition. ember.js deprecated both macros in emberjs/ember.js#21687 and emberjs/ember.js#21688. Apps with `RAISE_ON_DEPRECATION` fail, for example the Ember super-rentals tutorial build (ember-learn/super-rentals-tutorial#294). This PR replaces the two macros with `@computed` getters: - `messages` depends on `content.@each.message` and returns `A(...)`, the same as `mapBy`. - `isEmpty` depends on `length`. The tests in `tests/dont-write-new-tests-here/tests/unit/model/errors-test.js` cover both properties. No test app here runs ember-source `main`, so no test fails without this change. Expected changelog label: `:label: bug`. Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
This was referenced Oct 26, 2026
Add a `main` channel to the Build matrix. It uses the alpha ember-cli and app blueprint, then installs the latest ember-source build of ember.js main. ember.js CI uploads that build to builds.emberjs.com, and canary.json points to it. A hidden step after `ember new` installs the tarball when EMBER_SOURCE_TARBALL is set. Other channels do not set it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add an `ember-source` input to workflow_dispatch. It takes a full ember.js commit SHA or a tarball URL. A SHA maps to its build on builds.emberjs.com. If the input is empty, the main channel uses the latest build, as before. The step checks that the tarball exists, so a SHA with no build stops the job before the slow steps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NullVoxPopuli-ai-agent
force-pushed
the
nvp/ember-source-main
branch
from
October 28, 2026 17:49
6514d71 to
cee67aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
mainchannel to theBuildmatrix. It builds the tutorial against the latestember-sourcebuild ofemberjs/ember.jsmain.How it works:
mainjob installs the alphaember-cliand@ember/app-blueprint, the same asalpha.https://s3.amazonaws.com/builds.emberjs.com/canary.json. ember.js CI uploads a build of each push tomain, and this file points to the latest one.ember-sourceinput to a full ember.js commit SHA or a tarball URL. Themainjob then uses that build. If the input is empty, the job uses the latest build.ember newinstalls that tarball whenEMBER_SOURCE_TARBALLis set. The other channels do not set it, so nothing changes for them.The
mainjob is expected to fail now.@warp-drive/legacyusesmapByfrom@ember/object/computed, andmaindeprecates that macro. The tutorial setsRAISE_ON_DEPRECATION: true, so the firstpnpm testfails:The deploy jobs need all matrix jobs, the same as with
alpha. A brokenmainwill block deploys until it is fixed.PolarisMode tutorial PRs
Merge in this order:
ember-sourcemain.<LinkTo @model={{record}}>with PolarisMode records.useRecommendedStorewithout@warp-drive/legacy.Related:
@warp-drive/legacy(merged).🤖 Generated with Claude Code