Repository navigation
Use useRecommendedStore and drop @warp-drive/legacy - #338
Open
NullVoxPopuli-ai-agent wants to merge 1 commit into
Open
NullVoxPopuli-ai-agent wants to merge 1 commit into
NullVoxPopuli-ai-agent wants to merge 1 commit into
Conversation
New apps get a store from `useRecommendedStore` in `@warp-drive/core`, so records use PolarisMode. The blueprint no longer installs `@warp-drive/legacy`. On ember-source main, importing `@warp-drive/legacy` fails in apps that raise on deprecations, because its Errors class uses deprecated computed macros at module scope. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New apps now get their store from
useRecommendedStorein@warp-drive/core, so records use PolarisMode. The blueprint no longer installs@warp-drive/legacy.Why now: with
ember-sourcemain, a new app that setsRAISE_ON_DEPRECATION: truefails at boot. The blueprint store imports@warp-drive/legacy, and itsErrorsclass usesmapByandnotfrom@ember/object/computedat module scope.maindeprecates those macros. The super-rentals tutorial hits this in chapter 1. warp-drive-data/warp-drive#11540 (merged) fixes those macros, but new apps must not depend on the legacy package.The
warpdrive-jsandwarpdrive-tsfixtures now useuseRecommendedStoreandwithDefaultsfrom@warp-drive/core/reactive.Tests:
CI=true pnpm vitest run tests/warpdrive.test.mjs tests/tests.test.mjspasses, 11 of 11. This covers app tests, lint and glint for JS and TS.PolarisMode tutorial PRs
Merge in this order:
ember-sourcemain.<LinkTo @model={{record}}>with PolarisMode records.useRecommendedStorewithout@warp-drive/legacy.Related:
@warp-drive/legacy(merged).🤖 Generated with Claude Code