Improve table column and tag interactions#2396
Conversation
|
/preview |
|
Preview deployed
|
|
/preview |
|
/preview |
|
/preview |
|
/preview |
|
/preview |
|
/preview |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6f47d54f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| showType: !hasSingleTypeFilter(eventsQueryParameters.filter) | ||
| }); | ||
| }, | ||
| defaultColumnVisibility: defaultStackColumnVisibility, |
There was a problem hiding this comment.
Pass stack defaults into saved-view comparison
For any stack saved view created before these columns existed, columns lacks project and tags. The table now merges these false defaults into its current visibility, but the useSavedViews call above is not given defaultColumnVisibility, so columnsEqual sees two extra keys and reports the view as modified immediately; Reset only reapplies the legacy object and therefore cannot clear that state. Pass the same defaults to useSavedViews and cover legacy saved records missing the new keys.
AGENTS.md reference: AGENTS.md:L72-L75
Useful? React with 👍 / 👎.
Summary
Verification
npm run validateErrorCodeandObjectNamerender as structured rowsnpm run builddotnet test -- --filter-class Exceptionless.Tests.Api.Endpoints.EventEndpointTests(103 passed)OpenApiSnapshotTestsandSummaryDataTests(16 passed)Breaking changes
None. The response additions are backward compatible, and the new columns are hidden by default.