Document the Popover semantic contract - #5790
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
PR Analysis Report
Modified ComponentsPopover (@astryxdesign/core)
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | View full report |
cixzhang
force-pushed
the
docs/popover-contract
branch
from
September 1, 2026 06:06
eff53d6 to
ba08b1e
Compare
cixzhang
force-pushed
the
docs/popover-contract
branch
from
September 1, 2026 13:50
ba08b1e to
9b8ec1b
Compare
Contributor
Author
|
/approve-spec 9b8ec1b |
cixzhang
marked this pull request as ready for review
September 1, 2026 14:15
cixzhang
requested review from
imdreamrunner and
josephfarina
as code owners
September 1, 2026 14:15
Contributor
Author
|
/approve-spec 9b8ec1b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Popover has one painted surface, but the original draft described
popoverandpopover-surfaceas equal anatomy owners. Cindy’s final decision makespopoverthe canonical broad baseline while preserving existing themes through a documented compatibility window.What
current, approved bycixzhangon 2026-08-31.popover; remove the invented shared-hook anatomy part.surfaceTargetvalues as refinements on the same surface, and markpopover-surfaceas a deprecated compatibility alias.deprecatedFor, so no schema or validator change is needed.Risk
Documentation and inventory-test only. Runtime behavior and emitted classes are unchanged; existing
popover-surfacethemes keep working. Automatic hook-widepopoveremission and any later alias removal require separate implementation, release notes, and review. The PR remains draft for final parent review/merge. No Changeset.Testing
pnpm check:knowledgepnpm check:repo