Skip to content

Document the Popover semantic contract #5790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cixzhang merged 1 commit into from
Sep 1, 2026
+921 −105
Merged

Document the Popover semantic contract #5790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 29 additions & 7 deletions packages/cli/foundation/discovery/theming-targets.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,25 @@ describe('collectThemingTargets', () => {
).toBe(true);
});

it('keeps the deprecated Popover alias enumerable but out of active ownership', async () => {
const allPopoverKeys = (await enumerated)
.filter(target => target.component === 'Popover')
.map(target => target.key);
const activePopoverKeys = (await activeEnumerated)
.filter(target => target.component === 'Popover')
.map(target => target.key);
const doc = await loadComponentDoc(
path.join(coreSrc, 'Popover', 'Popover.doc.mjs'),
);

expect(allPopoverKeys).toEqual(['popover', 'popover-surface']);
expect(activePopoverKeys).toEqual(['popover']);
expect(doc.theming.targets).toContainEqual({
className: 'astryx-popover-surface',
deprecatedFor: 'popover',
});
});

it('carries the props and states a target reflects', async () => {
const targets = await enumerated;
expect(targets.find(t => t.key === 'switch-thumb')).toEqual({
Expand All @@ -89,13 +108,16 @@ describe('collectThemingTargets', () => {
['TableHeader', 'table-header'],
['TableBody', 'table-body'],
['TableFooter', 'table-footer'],
])('keeps %s theming metadata available in its direct doc', async (name, key) => {
const doc = await loadComponentDoc(
path.join(coreSrc, 'Table', `${name}.doc.mjs`),
);
expect(doc.subComponentOf).toBe('Table');
expect(doc.theming.targets).toContainEqual({className: `astryx-${key}`});
});
])(
'keeps %s theming metadata available in its direct doc',
async (name, key) => {
const doc = await loadComponentDoc(
path.join(coreSrc, 'Table', `${name}.doc.mjs`),
);
expect(doc.subComponentOf).toBe('Table');
expect(doc.theming.targets).toContainEqual({className: `astryx-${key}`});
},
);

it.each(['table-header', 'table-body', 'table-footer'])(
'enumerates %s once under its canonical Table owner',
Expand Down
Loading
Loading