Repository navigation
docs: changelog release myths and version-PR pitfalls - #15
Merged
garlobrian52 merged 1 commit intoAug 3, 2026
Merged
Conversation
getChangelogEntry always returns an object, so missing version headings do not throw on createRelease. Document script argv splitting, first-PR update only, and align createGithubReleases in action.yml with README. Co-authored-by: Mohamed <garlobrian52@users.noreply.github.com>
Changed Files
|
|
PR author is not in the allowed authors list. |
garlobrian52
marked this pull request as ready for review
August 3, 2026 01:38
Author
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_724e633a-1c5b-4c36-83b3-bb5daad31d0e) |
There was a problem hiding this comment.
Pull request overview
This PR updates documentation and action.yml input text to better match the action’s actual release/version behavior, especially around changelog parsing and Version Packages PR edge cases.
Changes:
- Corrects docs about
getChangelogEntrybehavior (missing version heading doesn’t throw; can yield full changelog body) and documents version/publish pitfalls (whitespacescript.split,CHANGELOG.mdrequirements, and only updating the first open version PR). - Renumbers troubleshooting sections and updates cross-links accordingly.
- Updates
action.ymlto clarify thatcreateGithubReleases: falseskips both tag pushes and GitHub Release creation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/troubleshooting.md | Updates troubleshooting guidance for release body/changelog behavior and adds a new section on Version Packages PR/script pitfalls. |
| docs/auth-and-publishing.md | Adjusts the troubleshooting section reference after renumbering. |
| docs/action-runtime.md | Expands/clarifies runtime documentation for runVersion, runPublish, and changelog parsing behavior. |
| action.yml | Aligns createGithubReleases input description with actual behavior (gates both tag pushes and Releases). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - Slices until the next heading of the **same depth**. | ||
| - Scans `major` / `minor` / `patch` in headings to compute `highestLevel` for sort order. | ||
| - Missing `CHANGELOG.md` for a changed package will throw when reading the file (version PR assembly expects changelogs unless the package did not change version). | ||
| - While walking that slice, headings containing `major` / `minor` / `patch` update `highestLevel` for `sortTheThings` (public packages before private; higher bump first). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Documentation follow-up after merged PR #14. Corrects inaccurate publish/changelog guidance discovered while verifying
getChangelogEntry/createReleaseagainst source, and documents a few version-path pitfalls that were easy to miss.Does not redo open PR #11 (
docs/maintainer-release.md/branchdefault).Docs added/updated
docs/action-runtime.md—getChangelogEntryalways returns an object; missing version heading → full changelog body (no throw). Version-path pitfalls: whitespacescript.split, empty# Releases, CHANGELOG required on version path, onlyexistingPullRequests.data[0]updated. Stale README cwd note removed.docs/troubleshooting.md— replace “missing entry throws” myth; new §5 for version PR / script pitfalls; renumber rate-limit / permissions sections.docs/auth-and-publishing.md— cross-link section number update.action.yml—createGithubReleasesdescription now matches README (false skips both tags and Releases).Codepaths covered
src/utils.ts→getChangelogEntrysrc/run.ts→createRelease,runVersion(script split, PR update, changelog read)src/index.ts→publish/versioninputs viarunPublish/runVersionaction.yml→createGithubReleasesKnowledge gaps addressed
ENOENTasymmetry was under-documented.version/publishare not shell-invoked; only the first open Version Packages PR is updated.action.ymlstill describedcreateGithubReleasesas Releases-only after README was fixed in docs: cwd accuracy, pushTag pitfalls, consumer troubleshooting #14.Verified against
src/utils.tsandsrc/run.ts(including a localgetChangelogEntrymissing-heading check).Summary by cubic
Clarifies release/version behavior in docs and aligns
action.ymlforcreateGithubReleases. Fixes incorrect guidance on changelog parsing and documents version-PR pitfalls to prevent confusion.getChangelogEntryalways returns{ content, highestLevel }; missing version heading falls back to the full changelog.CHANGELOG.md; publish path skipsENOENT.version/publishare split by whitespace only (no shell), and only the first open Version Packages PR is updated.action.ymlsocreateGithubReleases: falseskips both tag pushes and GitHub Releases.cwdnote; affirmed@changesets/cliresolution and root-package tag behavior.Written for commit 7475f21. Summary will update on new commits.
Note
Low Risk
Changes are documentation and
action.ymlinput descriptions only; no runtime code paths are modified.Overview
Documentation follow-up that aligns docs and
action.ymlwith actual runtime behavior after verifyinggetChangelogEntry,createRelease, andrunVersionin source.getChangelogEntry/ GitHub Releases: Docs no longer claim a missing version heading causes Release creation to throw. The helper always returns{ content, highestLevel }; a missing heading can put the entire changelog in the Release body. Troubleshooting now covers that symptom and the version vs publish asymmetry (version path throws on missingCHANGELOG.md; publish skipsENOENTper package).Version Packages PR pitfalls:
action-runtime.mddocuments whitespace-onlyscript.splitfor customversion/publish(no shell), empty# Releaseswhen versions don’t change, and that onlyexistingPullRequests.data[0]is updated when duplicate open PRs exist.createGithubReleases:action.ymldescription now statesfalseskips both tag pushes and GitHub Release creation, matching README andrunPublish(the flag gatespushTagandcreateReleasetogether).Minor doc maintenance: stale
cwdREADME note removed; troubleshooting sections renumbered; cross-links updated.Reviewed by Cursor Bugbot for commit 7475f21. Configure here.