Java: Delete old deprecated code.#21781
Open
aschackmull wants to merge 1 commit intogithub:mainfrom
Open
Conversation
aschackmull
added
no-change-note-required
Contributor
There was a problem hiding this comment.
Pull request overview
Removes long-deprecated Java CodeQL library APIs (including legacy local-source taint configs and various aliases/helpers) to reduce maintenance surface and encourage use of the current, threat-model-driven configurations and newer APIs.
Changes:
- Delete the deprecated MyBatis mapper XML library module file (its functionality already exists elsewhere in the MyBatis framework library).
- Remove deprecated “LocalFlow/LocalConfig” taint-tracking modules across multiple security libraries, leaving the modules as deprecated stubs where appropriate.
- Remove deprecated aliases/wrappers in core Java libraries (dataflow, controlflow/dominance, types/exprs/statements/members, and framework helpers).
Show a summary per file
| File | Description |
|---|---|
| java/ql/src/semmle/code/xml/MyBatisMapperXML.qll | Deletes deprecated MyBatis mapper XML library module. |
| java/ql/lib/semmle/code/java/security/XxeLocalQuery.qll | Removes deprecated local XXE flow config/flow; leaves deprecated stub module. |
| java/ql/lib/semmle/code/java/security/XssLocalQuery.qll | Removes deprecated local XSS flow config/flow; leaves deprecated stub module. |
| java/ql/lib/semmle/code/java/security/UrlRedirectLocalQuery.qll | Removes deprecated local URL redirect flow config/flow; leaves deprecated stub module. |
| java/ql/lib/semmle/code/java/security/TaintedPathQuery.qll | Removes deprecated local tainted-path flow config/flow. |
| java/ql/lib/semmle/code/java/security/SqlTaintedLocalQuery.qll | Removes deprecated local SQL injection flow config/flow; leaves deprecated stub module. |
| java/ql/lib/semmle/code/java/security/ResponseSplittingLocalQuery.qll | Removes deprecated local response-splitting flow config/flow; leaves deprecated stub module. |
| java/ql/lib/semmle/code/java/security/NumericCastTaintedQuery.qll | Removes deprecated local numeric-cast flow config/flow. |
| java/ql/lib/semmle/code/java/security/ImproperValidationOfArrayIndexLocalQuery.qll | Removes deprecated local improper-array-index flow config/flow; leaves deprecated stub module. |
| java/ql/lib/semmle/code/java/security/ImproperValidationOfArrayConstructionLocalQuery.qll | Removes deprecated local improper-array-construction flow config/flow; leaves deprecated stub module. |
| java/ql/lib/semmle/code/java/security/ExternallyControlledFormatStringLocalQuery.qll | Removes deprecated local format-string flow config/flow; leaves deprecated stub module. |
| java/ql/lib/semmle/code/java/security/ExecTaintedLocalQuery.qll | Removes deprecated local exec-taint flow config/flow; leaves deprecated stub module. |
| java/ql/lib/semmle/code/java/security/CommandLineQuery.qll | Removes deprecated remote/local exec-flow aliases and local config/flow. |
| java/ql/lib/semmle/code/java/security/ArithmeticTaintedQuery.qll | Removes deprecated remote overflow/underflow aliases. |
| java/ql/lib/semmle/code/java/security/ArithmeticTaintedLocalQuery.qll | Removes deprecated local overflow/underflow configs/flows; leaves deprecated stub module. |
| java/ql/lib/semmle/code/java/security/AndroidCertificatePinningQuery.qll | Removes deprecated isAndroid() predicate in favor of newer Android framework predicate. |
| java/ql/lib/semmle/code/java/frameworks/spring/SpringController.qll | Removes deprecated SpringRequestMappingMethod.getValue() alias. |
| java/ql/lib/semmle/code/java/frameworks/Jndi.qll | Removes deprecated LdapName.clone method wrapper class. |
| java/ql/lib/semmle/code/java/dataflow/internal/DataFlowNodes.qll | Removes deprecated location helper predicate wrapper. |
| java/ql/lib/semmle/code/java/dataflow/NullGuards.qll | Removes deprecated null-guard wrappers in favor of current APIs. |
| java/ql/lib/semmle/code/java/dataflow/FlowSummary.qll | Removes deprecated exported aliases for internal summary component types. |
| java/ql/lib/semmle/code/java/dataflow/FlowSources.qll | Removes deprecated ThreatModelFlowSource alias. |
| java/ql/lib/semmle/code/java/controlflow/Dominance.qll | Removes deprecated basic-block dominance predicate wrappers in favor of BasicBlock::* APIs. |
| java/ql/lib/semmle/code/java/Type.qll | Removes deprecated nestedName() alias. |
| java/ql/lib/semmle/code/java/Statement.qll | Removes deprecated PatternCase.getPattern() alias. |
| java/ql/lib/semmle/code/java/Member.qll | Removes deprecated Field.getSourceDeclaration() / Field.isSourceDeclaration() always-true helpers. |
| java/ql/lib/semmle/code/java/Expr.qll | Removes deprecated PatternExpr.asBindingPattern() alias. |
Copilot's findings
- Files reviewed: 27/27 changed files
- Comments generated: 0
aschackmull
force-pushed
the
java/rm-deprecated
branch
from
9c6609a to
44cc514
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.