Skip to content

Add AirGradient measurement interval select - #180319

Draft
samuelbles07 wants to merge 1 commit into
home-assistant:devfrom
samuelbles07:airgradient-measurement-interval-select
Draft

Add AirGradient measurement interval select#180319
samuelbles07 wants to merge 1 commit into
home-assistant:devfrom
samuelbles07:airgradient-measurement-interval-select

Conversation

@samuelbles07

Copy link
Copy Markdown
Contributor

Breaking change

None.

Proposed change

Add a measurement interval configuration select for AirGradient Go devices. The select exposes the curated intervals supported by the device firmware, from 3 seconds through 1 hour.

Validation

  • uv run --no-sync pytest tests/components/airgradient --cov=homeassistant.components.airgradient --cov-report=term-missing (85 passed, 174 snapshots, 100% coverage)
  • Changed-file prek checks passed, including hassfest.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A
  • Link to developer documentation pull request: N/A
  • Link to frontend pull request: N/A

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running: python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI balanced review requested due to automatic review settings August 26, 2026 16:55
@home-assistant

Copy link
Copy Markdown
Contributor

Hey there @airgradienthq, @joostlek, mind taking a look at this pull request as it has been labeled with an integration (airgradient) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of airgradient can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign airgradient Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

@samuelbles07
samuelbles07 marked this pull request as ready for review August 26, 2026 16:56
@samuelbles07
samuelbles07 requested a review from joostlek as a code owner August 26, 2026 16:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a configuration select for supported AirGradient Go measurement intervals.

Changes:

  • Defines supported interval options and device capability.
  • Adds localized labels.
  • Covers entity metadata and writes with tests.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
homeassistant/components/airgradient/const.py Adds the Go capability.
homeassistant/components/airgradient/select.py Implements the interval select.
homeassistant/components/airgradient/strings.json Adds option translations.
tests/components/airgradient/test_select.py Tests interval writes.
tests/components/airgradient/snapshots/test_select.ambr Records entity state and metadata.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@justanotherariel justanotherariel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a number entity instead? The API can report any number in between too, so we need to make sure to at least handle this too.

@justanotherariel
justanotherariel marked this pull request as draft August 27, 2026 09:51
@home-assistant
home-assistant Bot marked this pull request as draft August 27, 2026 09:51
@home-assistant

Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants