Skip to content

Add AirGradient measurement interval select #180319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samuelbles07 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add AirGradient measurement interval select #180319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions homeassistant/components/airgradient/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
LED_BAR_MODE = "led_bar_mode"
LED_BAR_BRIGHTNESS = "led_bar_brightness"
DISPLAY_BRIGHTNESS = "display_brightness"
MEASUREMENT_INTERVAL = "measurement_interval"
GPS_MODE = "gps_mode"
FRONT_LED_BRIGHTNESS = "front_led_brightness"
BACK_LED_BRIGHTNESS = "back_led_brightness"
Expand Down Expand Up @@ -62,6 +63,7 @@ class ModelCapabilities:
TVOC_LEARNING_OFFSET,
PM_STANDARD_CONFIG,
TEMPERATURE_UNIT,
MEASUREMENT_INTERVAL,
GPS_MODE,
FRONT_LED_BRIGHTNESS,
BACK_LED_BRIGHTNESS,
Expand Down
13 changes: 13 additions & 0 deletions homeassistant/components/airgradient/select.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ class AirGradientSelectEntityDescription(SelectEntityDescription):
"720",
]

MEASUREMENT_INTERVAL_OPTIONS = ["3", "10", "30", "60", "300", "900", "3600"]

ABC_DAYS = [
"1",
"7",
Expand Down Expand Up @@ -161,6 +163,17 @@ def _get_led_level(value: int | None, options: list[str]) -> str | None:
)

GO_SELECT_ENTITIES: tuple[AirGradientSelectEntityDescription, ...] = (
AirGradientSelectEntityDescription(
key="measurement_interval",
translation_key="measurement_interval",
options=MEASUREMENT_INTERVAL_OPTIONS,
entity_category=EntityCategory.CONFIG,
config_key="measurement_interval",
value_fn=lambda config: _get_value(
config.measurement_interval, MEASUREMENT_INTERVAL_OPTIONS
),
set_value_fn=lambda client, value: client.set_measurement_interval(int(value)),
),
AirGradientSelectEntityDescription(
key="gps_mode",
translation_key="gps_mode",
Expand Down
12 changes: 12 additions & 0 deletions homeassistant/components/airgradient/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,18 @@
"pm": "Particulate matter"
}
},
"measurement_interval": {
"name": "Measurement interval",
"state": {
"3": "3 seconds",
"10": "10 seconds",
"30": "30 seconds",
"60": "1 minute",
"300": "5 minutes",
"900": "15 minutes",
"3600": "1 hour"
}
},
"nox_index_learning_time_offset": {
"name": "NOx index learning offset",
"state": {
Expand Down
69 changes: 69 additions & 0 deletions tests/components/airgradient/snapshots/test_select.ambr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,6 +1127,75 @@
'state': 'tracking',
})
# ---
# name: test_v1_entities[select.airgradient_measurement_interval-entry]
EntityRegistryEntrySnapshot({
'aliases': list([
None,
]),
'area_id': None,
'capabilities': dict({
<SelectEntityCapabilityAttribute.OPTIONS: 'options'>: list([
'3',
'10',
'30',
'60',
'300',
'900',
'3600',
]),
}),
'config_entry_id': <ANY>,
'config_subentry_id': <ANY>,
'device_class': None,
'device_id': <ANY>,
'disabled_by': None,
'domain': 'select',
'entity_category': <EntityCategory.CONFIG: 'config'>,
'entity_id': 'select.airgradient_measurement_interval',
'has_entity_name': True,
'hidden_by': None,
'icon': None,
'id': <ANY>,
'labels': set({
}),
'name': None,
'object_id_base': 'Measurement interval',
'options': dict({
}),
'original_device_class': None,
'original_icon': None,
'original_name': 'Measurement interval',
'platform': 'airgradient',
'previous_unique_id': None,
'suggested_object_id': None,
'supported_features': 0,
'translation_key': 'measurement_interval',
'unique_id': '84fce612f5b8-measurement_interval',
'unit_of_measurement': None,
})
# ---
# name: test_v1_entities[select.airgradient_measurement_interval-state]
StateSnapshot({
'attributes': ReadOnlyDict({
<EntityStateAttribute.FRIENDLY_NAME: 'friendly_name'>: 'Airgradient Measurement interval',
<SelectEntityCapabilityAttribute.OPTIONS: 'options'>: list([
'3',
'10',
'30',
'60',
'300',
'900',
'3600',
]),
}),
'context': <ANY>,
'entity_id': 'select.airgradient_measurement_interval',
'last_changed': <ANY>,
'last_reported': <ANY>,
'last_updated': <ANY>,
'state': '10',
})
# ---
# name: test_v1_entities[select.airgradient_nox_index_learning_offset-entry]
EntityRegistryEntrySnapshot({
'aliases': list([
Expand Down
6 changes: 6 additions & 0 deletions tests/components/airgradient/test_select.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,12 @@ async def test_v1_entities(
"set_co2_automatic_baseline_calibration",
0,
),
(
"select.airgradient_measurement_interval",
"300",
"set_measurement_interval",
300,
),
],
)
async def test_v1_select_writes(
Expand Down
Loading