Migrate documentation from MkDocs to Docsy#4734
Migrate documentation from MkDocs to Docsy#4734iromanycheva-eng wants to merge 4 commits intokubernetes-sigs:mainfrom
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: iromanycheva-eng The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @iromanycheva-eng. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
f40ad5c to
5e1c8a3
Compare
791ced0 to
39ab797
Compare
|
Looks like all moved or renamed files are added as new in this PR. Can we mark them as moved instead? |
39ab797 to
7e67079
Compare
7e67079 to
2e331d5
Compare
|
This looks really great! A couple of things that I think could be better though: The Overview style pages would ideally be the landing page for each of the headings, as they are today, rather than the table of contents that they are in the current state. So:
When navigating GEPs, the table of contents on the left disappears when you get down to the actual GEP itself. Ideally this would at least show the parent, or auto-expand the current section or something. Aside from that, I think this is looking pretty close. Shockingly so, well done. |
|
/ok-to-test |
5d645f8 to
e3facf6
Compare
e3facf6 to
e55be90
Compare
27d825e to
cdbe928
Compare
cdbe928 to
449007c
Compare
|
This is looking LGTM to me, but I think it may need to wait until after next Friday, when I merge the Implementations Page review for v1.5. I think that's the only docs PR we have in flight, but I can't merge that earlier for process fairness reasons. |
|
/hold |
|
@youngnick can we hold until next week? I still need to finalize the python script for redirect :D I will try my best to do it today or early next week! Thanks! |
| docker build --pull -t gaie/mkdocs hack/mkdocs/image | ||
| docker rm -f $(DOCS_BUILD_CONTAINER_NAME) || true | ||
| docker run --name $(DOCS_BUILD_CONTAINER_NAME) --rm -v ${PWD}:/docs gaie/mkdocs build | ||
| docker run --rm -v ${PWD}:/src -w /src/site peaceiris/hugo:v0.148.0-extended hugo |
There was a problem hiding this comment.
maybe make this version configurable somewhere or a flag on the Makefile
|
|
||
| ```yaml | ||
| {% include 'standard/simple-http-https/gateway.yaml' %} | ||
| apiVersion: gateway.networking.k8s.io/v1 |
There was a problem hiding this comment.
can't we have this include on docsy anymore? I think that on Kubernetes docs they do it, maybe it is worth using the same or similar approach
There was a problem hiding this comment.
I'll try to find the solution and create a separate commit for it.
Redirect section headers to the first subtree content page instead of the TOC. Include breadcrumbs in Geps to enhance user navigation.
Also upgrade version of hugo and docsy
1cc82b1 to
8aa304a
Compare
What type of PR is this?
/kind documentation
Optionally add one or more of the following kinds if applicable:
What this PR does / why we need it:
We need to migrate documentation from MkDocs to Docsy because there is a better support for google analytics. Besides Docsy is a recommended theme for kubernetes sites.
Which issue(s) this PR fixes:
Fixes #4729
Does this PR introduce a user-facing change?: