fix: correct syntax error in HTTPRouteMatch, GRPCRouteMatch examples#4763
fix: correct syntax error in HTTPRouteMatch, GRPCRouteMatch examples#4763opp-13 wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: opp-13 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @opp-13. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
| // name: "version" | ||
| // value "v1" | ||
| // | ||
| // matches: |
There was a problem hiding this comment.
the tabs are not correctly rendeded on the docs, see: https://deploy-preview-4763--kubernetes-sigs-gateway-api.netlify.app/reference/spec/#grpcroutematch
There was a problem hiding this comment.
Could you please redeploy the preview?
I don’t believe my commit affected the docs preview (value "v1" → value: "v1")
https://deploy-preview-4763--kubernetes-sigs-gateway-api.netlify.app/reference/spec/#httproutematch
Local testing with 'make verify-docs' and 'make live-docs' works correctly.
The link below shows that tabs are present in example yaml but the behavior is still working as expected:
https://gateway-api.sigs.k8s.io/reference/spec/#httproutematch
https://github.com/kubernetes-sigs/gateway-api/blob/main/apis/v1/httproute_types.go#L750-L759
Thank you!
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Fix syntax errors in HTTPRouteMatch, GRPCRouteMatch examples.
Change:
P.S.
Update grpcroute example yaml formatting (indentation) based on apis/v1/httproute_types.go (lines 750–759) to pass make verify.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: