Skip to content

fix: correct syntax error in HTTPRouteMatch, GRPCRouteMatch examples#4763

Open
opp-13 wants to merge 1 commit intokubernetes-sigs:mainfrom
opp-13:main
Open

fix: correct syntax error in HTTPRouteMatch, GRPCRouteMatch examples#4763
opp-13 wants to merge 1 commit intokubernetes-sigs:mainfrom
opp-13:main

Conversation

@opp-13
Copy link
Copy Markdown

@opp-13 opp-13 commented Apr 17, 2026

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Fix syntax errors in HTTPRouteMatch, GRPCRouteMatch examples.

Change:

  • apis/v1/httproute_types.go
    • value "v1" → value: "v1"
  • apis/v1/grpcroute_types.go
    • value "v1" → value: "v1"
    • fix yaml indentation & list formatting

P.S.
Update grpcroute example yaml formatting (indentation) based on apis/v1/httproute_types.go (lines 750–759) to pass make verify.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 17, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: opp-13
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 17, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @opp-13. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@snorwin
Copy link
Copy Markdown
Member

snorwin commented Apr 17, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 17, 2026
// name: "version"
// value "v1"
//
// matches:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Author

@opp-13 opp-13 Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please redeploy the preview?

I don’t believe my commit affected the docs preview (value "v1" → value: "v1")
https://deploy-preview-4763--kubernetes-sigs-gateway-api.netlify.app/reference/spec/#httproutematch

Local testing with 'make verify-docs' and 'make live-docs' works correctly.

The link below shows that tabs are present in example yaml but the behavior is still working as expected:
https://gateway-api.sigs.k8s.io/reference/spec/#httproutematch
https://github.com/kubernetes-sigs/gateway-api/blob/main/apis/v1/httproute_types.go#L750-L759

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants