-
Notifications
You must be signed in to change notification settings - Fork 702
fix: correct syntax error in HTTPRouteMatch, GRPCRouteMatch examples #4763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the tabs are not correctly rendeded on the docs, see: https://deploy-preview-4763--kubernetes-sigs-gateway-api.netlify.app/reference/spec/#grpcroutematch
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please redeploy the preview?
I don’t believe my commit affected the docs preview (value "v1" → value: "v1")
https://deploy-preview-4763--kubernetes-sigs-gateway-api.netlify.app/reference/spec/#httproutematch
Local testing with 'make verify-docs' and 'make live-docs' works correctly.
The link below shows that tabs are present in example yaml but the behavior is still working as expected:
https://gateway-api.sigs.k8s.io/reference/spec/#httproutematch
https://github.com/kubernetes-sigs/gateway-api/blob/main/apis/v1/httproute_types.go#L750-L759
Thank you!