[Fortran][test-suite] Update empty BIND(C) derived type expectations#387
[Fortran][test-suite] Update empty BIND(C) derived type expectations#387
Conversation
tarunprabhu
left a comment
tarunprabhu
left a comment
There was a problem hiding this comment.
Please do not update tests.cmake by hand. There is a large banner at the top that says that file must not be edited.
If the file is xfail in flang but is expected to pass in gfortran, see the README.md on how to use override.yaml to override the annotations.
Saieiei
force-pushed
the
flang-bind-c-empty-derived-type-xfail
branch
from
553e1ab to
7299791
Compare
|
My bad, I should have caught that. Thanks. I switched this to use |
Update the empty BIND(C) derived type tests to match Flang's current behavior. empty_derived_type.f90 is now marked xfail, and empty_derived_type_2.f90 is removed from FAILING_FILES because Flang now produces the expected error.
Saieiei
force-pushed
the
flang-bind-c-empty-derived-type-xfail
branch
from
7299791 to
e512115
Compare
tarunprabhu
left a comment
tarunprabhu
left a comment
There was a problem hiding this comment.
Thanks. A small request and we should be good to go.
| "unsigned_21.f90": | ||
| disabled_on: ["powerpc-*-aix"] | ||
|
|
||
| # Flang now diagnoses empty BIND(C) derived types as errors. |
There was a problem hiding this comment.
Do you mind providing a bit more context here? Something like the following.
| # Flang now diagnoses empty BIND(C) derived types as errors. | |
| # Flang now diagnoses empty BIND(C) derived types as errors. gfortran issues | |
| # a warning in this case. |
2 participants
This updates the Fortran test-suite fallout from llvm/llvm-project#193452.
Flang now correctly diagnoses empty
BIND(C)derived types as errors, soempty_derived_type.f90is markedxfail, andempty_derived_type_2.f90is removed fromFAILING_FILESnow that it produces the expected error.