feat(proto): add TransportType (TCP/RDMA) to spdkrpc + imrpc - #121
Draft
abonillabeeche wants to merge 2 commits into
Draft
feat(proto): add TransportType (TCP/RDMA) to spdkrpc + imrpc#121abonillabeeche wants to merge 2 commits into
abonillabeeche wants to merge 2 commits into
Conversation
This was referenced Aug 20, 2026
Draft
Add a DataEngineTransport enum (TCP=0 default, RDMA=1) and thread a data_engine_transport field through: - spdkrpc.EngineCreateRequest (field 15) and ReplicaCreateRequest (field 7) - imrpc.SpdkInstanceSpec (field 17) Mirrors the DataLayoutType precedent. Unset==TCP preserves behavior for all existing volumes. Ref: longhorn/longhorn#13796 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
abonillabeeche
force-pushed
the
rdma-transport
branch
from
August 20, 2026 05:18
1fbbe06 to
bd37823
Compare
abonillabeeche
changed the title
Address review on longhorn/longhorn-spdk-engine#654: this proto lives in a v2-data-engine-only surface, and this repo's convention is TransportType, so drop the DataEngine prefix on the generated type. - imrpc/spdkrpc: enum DataEngineTransport -> TransportType, values DATA_ENGINE_TRANSPORT_{TCP,RDMA} -> TRANSPORT_TYPE_{TCP,RDMA}, field data_engine_transport -> transport_type. Wire-compatible: field numbers and enum values are unchanged, so already deployed peers keep interoperating; only source that references the Go/py identifiers must be recompiled. Ref: longhorn/longhorn#13796 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
abonillabeeche
added a commit
to abonillabeeche/longhorn-spdk-engine
that referenced
this pull request
Aug 22, 2026
Rename the struct field to TransportType on Engine and Replica and the client-method params to transportType, and consume the renamed spdkrpc.TransportType enum. No behavior change. Ref: longhorn/longhorn#13796 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
abonillabeeche
added a commit
to abonillabeeche/longhorn-instance-manager
that referenced
this pull request
Aug 22, 2026
Consume the renamed imrpc/spdkrpc TransportType enum and rename the IM-side field/params and the IM->SPDK conversion helper accordingly. No behavior change. Ref: longhorn/longhorn#13796 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
abonillabeeche
added a commit
to abonillabeeche/longhorn-manager
that referenced
this pull request
Aug 22, 2026
The v2 proto enum was renamed DataEngineTransport -> TransportType in longhorn/types#121. Adapt at the instance-manager client boundary: the generated imrpc type is now imrpc.TransportType and the IM client request field is TransportType. longhorn-manager keeps its own DataEngineTransport type and VolumeSpec field name (this repo's convention), converting to the renamed enum in toIMRPCDataEngineTransport and setting the renamed IM client field. No behavior change. Ref: longhorn/longhorn#13796 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Alejandro Bonilla <abonilla@suse.com>
abonillabeeche
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of longhorn/longhorn#13796 (RDMA NVMe-oF transport for the v2 data engine).
Adds a
TransportTypeenum (TRANSPORT_TYPE_TCP = 0,TRANSPORT_TYPE_RDMA = 1) to the imrpc and spdkrpc protobufs and threads atransport_typefield onto the instance/engine/replica create messages, plus the regenerated Go and Python bindings.TRANSPORT_TYPE_TCP = 0is the zero value, so absent/old peers deserialize to TCP and behavior is unchanged.The enum was originally proposed as
DataEngineTransport; renamed toTransportTypeper review on longhorn/longhorn-spdk-engine#654. Field numbers and enum values are unchanged, so the rename is wire-compatible — deployed peers keep interoperating and only source recompiles.This is the base of a 5-repo change; nothing consumes the new field yet.
Files:
protobuf/imrpc/{common,instance}.proto,protobuf/spdkrpc/spdk.proto(+ regeneratedpkg/generated/**,generated-py/**).