Fix runner.js HTTP error handling to properly propagate fetch errors#1435
Open
MatrixNeoKozak wants to merge 2 commits into
Open
Fix runner.js HTTP error handling to properly propagate fetch errors#1435MatrixNeoKozak wants to merge 2 commits into
MatrixNeoKozak wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The request function in runner.js had a bug in the .then handler that referenced an undefined variable 'err' when checking resp.ok. This caused fetch errors (non-2xx status) to throw an unhandled promise rejection instead of properly calling the callback with an error. Fixed by using the resp.statusText directly and ensuring the error object is correctly constructed.