Skip to content

Fix runner.js HTTP error handling to properly propagate fetch errors #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatrixNeoKozak wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix runner.js HTTP error handling to properly propagate fetch errors #1435

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d61be8e
Fix runner.js HTTP error handling to properly propagate fetch errors
May 31, 2026
0b2761a
Merge branch 'master' into scout-improvement-1780226958264
macbre Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions lib/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,9 @@ async function request(requestOptions, callback) {
debug("Headers: %j", resp.headers._headers);

if (!resp.ok) {
var err = new Error(
"HTTP request failed: " +
(err
? err.toString()
: "received HTTP " + resp.status + " " + resp.statusText),
);
callback(err);
callback(new Error(
"HTTP request failed: received HTTP " + resp.status + " " + resp.statusText
));
} else {
return resp.text(); // a promise
}
Expand Down
Loading