Remove dependency on gazetteer - #1898
Conversation
e6254e9 to
02e9dd9
Compare
|
Thanks for taking the time to open this PR! |
|
Bundle size report: Size Change: 0 B
ℹ️ View DetailsNo major changes |
|
@HarelM Good points. I'm skeptical that this file has enough going on in it to provide meaningful performance metrics. Is there a meatier GeoJSON file to use instead? |
|
The removed benchmark is actually very valuable and has itself nothing todo with geojson. The geojson is only used as a list of locations to benchmark. I agree that we should just include a copy of the file in this repository, which also would allow us the add/remove locations from the benchmark if we want to. |
e84ed17 to
5a2b22d
Compare
|
@xabbu42 I totally misunderstood you - thanks for your patience! Yes, it does seem this benchmark does something, though I still can't say I truly grasp how the benchmarks work! |
|
@rotu no worries, thanks for taking the time to improve maplibre! |
5a2b22d to
34ed2b7
Compare
Removes dependency on gazetteer, which was only being used for a single GeoJSON file for benchmarks but pulled in a number of deprecated packages.
Fix #1897
Launch Checklist
CHANGELOG.mdunder the## mainsection.