Fix minor bug in get_number_summary - Use class instead of instance for static fields#837
Merged
QuanyiLi merged 1 commit intometadriverse:mainfrom Apr 25, 2025
Merged
Conversation
In `get_number_summary`, a few static fields and functions were being accessed from an instance of ScenarioDescription rather than the class.
Member
|
@LLeon360 Thank you for the bug-fixing! I have merged this into the main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
get_number_summary, a few static fields and functions were being accessed from an instance of ScenarioDescription rather than the class.What changes do you make in this PR?
In
scenario_description.pytheget_number_summaryfunction does not work because it tries to use an instance of ScenarioDescription instead of the class itself to try to call static functions and use constants that are defined in the class. I replaced these instances with the class.Fix minor bug
Checklist
bash scripts/format.shbefore merging.