[202x] Fix invalid conforming literals warning - #9002
Open
Chris B (llvm-beanz) wants to merge 2 commits into
Open
Chris B (llvm-beanz) wants to merge 2 commits into
Chris B (llvm-beanz) wants to merge 2 commits into
Conversation
The warning for legacy literals changing signedness was firing even on explicitly suffixed unsigned literals. This change fixes the invalid warning by not issuing it if the literal is explicitly unsigned. Fixes microsoft#7864 ../tools/clang/test/SemaHLSL/v202x/conforming-literals/valid-literals.hl sl
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
It leaves the issue’s explicit-cast cases unresolved and needs legacy-path coverage and a release note.
Review effort: Balanced
Findings: 2
Open (3)
What changed in this PR
Suppresses invalid legacy-literal signedness warnings for explicitly unsigned literals.
Changes:
- Checks
Literal.isUnsignedbefore emitting warnings. - Adds regression coverage for unsigned suffixes and casts.
| File | Description |
|---|---|
tools/clang/lib/Sema/SemaExpr.cpp |
Suppresses warnings for unsigned-suffixed literals. |
tools/clang/test/SemaHLSL/v202x/conforming-literals/valid-literals.hlsl |
Adds diagnostic regression cases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
../tools/clang/test/SemaHLSL/v202x/conforming-literals/valid-literals.hl sl
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning for legacy literals changing signedness was firing even on explicitly suffixed unsigned literals. This change fixes the invalid warning by not issuing it if the literal is explicitly unsigned.
Fixes #7864