Skip to content

[202x] Fix invalid conforming literals warning #9002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chris B (llvm-beanz) merged 2 commits into from
Oct 6, 2026
Merged

[202x] Fix invalid conforming literals warning #9002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1467ae6
[202x] Fix invalid conforming literals warning
llvm-beanz Oct 5, 2026
043f848
Update based on copilot review feedback
llvm-beanz Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/ReleaseNotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ line upon naming the release. Refer to previous for appropriate section names.
[#8964](https://github.com/microsoft/DirectXShaderCompiler/issues/8964).
- Add `static_assert` matching C++11 and C++17 under HLSL 202x
([#8910](https://github.com/microsoft/DirectXShaderCompiler/issues/8910)).
- Fix HLSL 202x conforming literals false-positive warning for hex literal
signedness
([#7864](https://github.com/microsoft/DirectXShaderCompiler/issues/7864)).

#### Bug Fixes

Expand Down
4 changes: 2 additions & 2 deletions tools/clang/lib/Sema/SemaExpr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3540,7 +3540,7 @@ ExprResult Sema::ActOnNumericConstant(const Token &Tok, Scope *UDLScope) {
if (Val < std::numeric_limits<uint32_t>::max())
Width = 32;
uint64_t MSB = 1ull << (Width - 1);
if ((Val & MSB) != 0)
if (!Literal.isUnsigned && (Val & MSB) != 0)
Comment thread
llvm-beanz marked this conversation as resolved.
Diag(Tok.getLocation(),
diag::warn_hlsl_legacy_integer_literal_signedness);
}
Expand Down Expand Up @@ -3702,7 +3702,7 @@ ExprResult Sema::ActOnNumericConstant(const Token &Tok, Scope *UDLScope) {
// HLSL Change Begin - 202x integer warnings.
if (Literal.getRadix() != 10) {
uint64_t Val = ResultVal.getLimitedValue();
if ((Val & MSB) != 0)
if (!Literal.isUnsigned && (Val & MSB) != 0)
Diag(Tok.getLocation(),
diag::warn_hlsl_legacy_integer_literal_signedness);
}
Expand Down
12 changes: 12 additions & 0 deletions tools/clang/test/SemaHLSL/v202x/conforming-literals/valid-literals.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@ _Static_assert(is_same<__decltype(0x7000000000000000), int64_t>::value, "0x70000
// expected-warning@+1{{literal value is treated as signed in HLSL 2021 and earlier, and unsigned in later language versions}}
_Static_assert(is_same<__decltype(0xF000000000000000), uint64_t>::value, "0xF000000000000000 is uint64_t");

static const uint Suffixed = 0xFFF00000u; // No warning here!
// expected-warning@+1{{literal value is treated as signed in HLSL 2021 and earlier, and unsigned in later language versions}}
static const uint CastedUnsigned = (uint)0xFFF00000;
// expected-warning@+1{{literal value is treated as signed in HLSL 2021 and earlier, and unsigned in later language versions}}
static const int CastedSigned = (int)0xFFF00000;
Comment thread
Copilot marked this conversation as resolved.

#else
// The `literal float` typename is not spellable so we cannot verify the truth
// in this way.
Expand Down Expand Up @@ -118,6 +124,12 @@ uint OctSignedBitMask32() {
uint64_t OctSignedBitMask64() {
return 0400000000000000000000; // No warning
}

static const uint Suffixed = 0xFFF00000u; // No warning here!
// expected-warning@+1{{literal value is treated as signed in HLSL 2021 and earlier, and unsigned in later language versions}}
static const uint CastedUnsigned = (uint)0xFFF00000;
// expected-warning@+1{{literal value is treated as signed in HLSL 2021 and earlier, and unsigned in later language versions}}
static const int CastedSigned = (int)0xFFF00000;
#endif

////////////////////////////////////////////////////////////////////////////////
Expand Down
Loading