Use AsyncIterableProducer for document diff changes#318296
Open
aydinomer00 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the async iterable implementation used for streaming text diff changes in the extension host API to use the newer AsyncIterableProducer utility.
Changes:
- Swapped
AsyncIterableObjectforAsyncIterableProducerin imports. - Updated the cancellation/empty-stream return to use
AsyncIterableProducer.EMPTY. - Updated the diff change stream construction to instantiate
AsyncIterableProducer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #256854
This migrates the
getTextDiffchanges iterable fromAsyncIterableObjecttoAsyncIterableProducer.The document diff API currently computes all changes once and emits them once, so the iterable does not need to retain emitted values for later re-iteration. Using
AsyncIterableProduceravoids keeping those emitted values in the async iterable implementation.Validation:
nvm use && npm run compile-check-ts-nativeNotes:
npm installstopped while installingremote/node_modulesbecause the local machine ran out of disk space (ENOSPC), but this change only touchessrc/and the targeted compile check passed.