Skip to content

Use AsyncIterableProducer for document diff changes #318296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aydinomer00 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Use AsyncIterableProducer for document diff changes #318296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/vs/workbench/api/common/extHost.api.impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import type * as vscode from 'vscode';
import { CancellationTokenSource } from '../../../base/common/cancellation.js';
import { AsyncIterableObject, raceCancellationError } from '../../../base/common/async.js';
import { AsyncIterableProducer, raceCancellationError } from '../../../base/common/async.js';
import * as errors from '../../../base/common/errors.js';
import { Emitter, Event } from '../../../base/common/event.js';
import { combinedDisposable } from '../../../base/common/lifecycle.js';
Expand Down Expand Up @@ -1171,7 +1171,7 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
if (token?.isCancellationRequested) {
const error = new errors.CancellationError();
return {
changes: AsyncIterableObject.EMPTY,
changes: AsyncIterableProducer.EMPTY,
complete: Promise.reject(error),
};
}
Expand Down Expand Up @@ -1203,7 +1203,7 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
// In the future, we may want to stream changes incrementally as they are computed
// (e.g. by having the worker yield partial results).
return {
changes: new AsyncIterableObject<vscode.TextDiffChange>(async emitter => {
changes: new AsyncIterableProducer<vscode.TextDiffChange>(async emitter => {
const result = await mappedPromise;
emitter.emitMany(result.changes.map(mapChange));
}),
Expand Down