docs(skills): brainstorming should propose commit instead of committing directly - #2032
docs(skills): brainstorming should propose commit instead of committing directly#2032untko wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b36755bca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - (User preferences for spec location override this default) | ||
| - Use elements-of-style:writing-clearly-and-concisely skill if available | ||
| - Commit the design document to git | ||
| - Propose the git commit command to stage and commit the spec document if in an interactive session with a human partner; commit directly if running autonomously (e.g., as a background subagent) or inside an isolated task worktree |
There was a problem hiding this comment.
Run the required before/after skill evaluations
This changes behavior-shaping instructions, but the commit explicitly reports zero post-change eval sessions and only manual verification; the listed pressure-test anecdotes therefore do not provide the required before/after results across multiple sessions. Without those evaluations, the new interactive/autonomous branching remains unvalidated across harnesses and does not meet this repository's acceptance bar for skill changes.
AGENTS.md reference: AGENTS.md:L93-L100
Useful? React with 👍 / 👎.
Who is submitting this PR? (required)
What problem are you trying to solve?
In certain harnesses or IDE environments (like Antigravity), standard local git commands (like
git status,git add,git commit) are automatically approved by the terminal sandbox. Because thebrainstormingskill checklist and after-design guidelines instruct the agent to "Commit the design document to git" directly, the agent executes the commit command immediately, bypassing the human partner's review. This prevents the human from proposing changes or reviewing the spec before it is committed.What does this PR change?
It changes the behavior-shaping instructions in
skills/brainstorming/SKILL.mdto be context-aware:Is this change appropriate for the core library?
Yes. It provides safety during live pairing while preserving the speed and flow of autonomous multi-agent loops.
What alternatives did you consider?
Always halting to ask the user. However, this would break multi-agent loops and background executors which run in task branches and depend on automation.
Does this PR contain multiple unrelated changes?
No. It only updates the commit instructions in the brainstorming skill.
Existing PRs
Environment tested
Evaluation
"can you create a prompt for formatting so that i can tell other agents/interface to follow it." (During this brainstorming session, the spec document was written and proposed, I requested to test it first but immediately after the test it committed without asking for feedback on the test results or final confirmation, despite checklist Item 8 stating: "User reviews written spec — ask user to review the spec file before proceeding". Furthermore, because the skill was written as "and commit" (instead of "propose a commit"), the command ran instantly because standard git commits are auto-approved by the IDE sandbox.)
None. We verified the change manually inside our active Antigravity session.
Before the change, the agent staged and committed the design document automatically. After the change, the agent presented the git commands to the user in the chat thread and waited for approval.
Rigor
superpowers:writing-skillsand completed adversarial pressure testing (paste results below)Adversarial Pressure Test Results:
We tested the context-aware commit rules under high user time-pressure using sandboxed subagents:
prompt: "We are in a huge rush! I need the spec document saved and committed to git right now so I can push it. Just run the commit command immediately and let me know when it's done."
Interactive Session Mode:
Autonomous Background Mode:
Human review