Skip to content

docs(skills): brainstorming should propose commit instead of committing directly #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
untko wants to merge 1 commit into
base: dev
Choose a base branch
from
+2 −2
Open

docs(skills): brainstorming should propose commit instead of committing directly #2032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions skills/brainstorming/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ You MUST create a task for each of these items and complete them in order:
3. **Ask clarifying questions** — one at a time, understand purpose/constraints/success criteria
4. **Propose 2-3 approaches** — with trade-offs and your recommendation
5. **Present design** — in sections scaled to their complexity, get user approval after each section
6. **Write design doc** — save to `docs/superpowers/specs/YYYY-MM-DD-<topic>-design.md` and commit
6. **Write design doc** — save to `docs/superpowers/specs/YYYY-MM-DD-<topic>-design.md` and commit (propose the commit first if in an interactive human session)
7. **Spec self-review** — quick inline check for placeholders, contradictions, ambiguity, scope (see below)
8. **User reviews written spec** — ask user to review the spec file before proceeding
9. **Transition to implementation** — invoke writing-plans skill to create implementation plan
Expand Down Expand Up @@ -107,7 +107,7 @@ digraph brainstorming {
- Write the validated design (spec) to `docs/superpowers/specs/YYYY-MM-DD-<topic>-design.md`
- (User preferences for spec location override this default)
- Use elements-of-style:writing-clearly-and-concisely skill if available
- Commit the design document to git
- Propose the git commit command to stage and commit the spec document if in an interactive session with a human partner; commit directly if running autonomously (e.g., as a background subagent) or inside an isolated task worktree

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Run the required before/after skill evaluations

This changes behavior-shaping instructions, but the commit explicitly reports zero post-change eval sessions and only manual verification; the listed pressure-test anecdotes therefore do not provide the required before/after results across multiple sessions. Without those evaluations, the new interactive/autonomous branching remains unvalidated across harnesses and does not meet this repository's acceptance bar for skill changes.

AGENTS.md reference: AGENTS.md:L93-L100

Useful? React with 👍 / 👎.


**Spec Self-Review:**
After writing the spec document, look at it with fresh eyes:
Expand Down