[SP-374] Fix JSON file upload MIME detection in Ruby SDK - #228
Merged
Conversation
…s (SP-374) Marcel::MimeType.for(Pathname) relies on magic bytes and fails to detect application/json for .json files, returning application/octet-stream instead. This causes a 422 validation error from the API when uploading NFC data. Add a fallback to Marcel::MimeType.for(extension:) when the pathname-based detection returns application/octet-stream, aligning Ruby with all other SDKs which use extension-based MIME detection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
DavidMealha-Onfido
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Marcel::MimeType.for(Pathname)relies on magic bytes and fails to detectapplication/jsonfor.jsonfiles, returningapplication/octet-streaminstead. This causes a 422 validation error from the API when uploading NFC data viaonfido-ruby.Fix
Added a fallback in
api_client_faraday_partial.mustache: when Marcel's pathname-based detection returnsapplication/octet-stream, fall back toMarcel::MimeType.for(extension:)which correctly resolves the MIME type from the file extension.This aligns Ruby with all other SDKs (Python, Java, PHP, Node) which already use extension-based MIME detection.
Testing