Skip to content

[SP-374] Fix JSON file upload MIME detection in Ruby SDK #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvacca-onfido merged 1 commit into from
Aug 24, 2026
Merged

[SP-374] Fix JSON file upload MIME detection in Ruby SDK #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion generators/ruby/faraday/templates/api_client_faraday_partial.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,13 @@
form_params.each do |key, value|
case value
when ::File, ::Tempfile
data[key] = Faraday::FilePart.new(value.path, Marcel::MimeType.for(Pathname.new(value.path)))
{{! SP-374: Marcel MIME fallback for unrecognized extensions (e.g. .json) - BEGIN }}
mime = Marcel::MimeType.for(Pathname.new(value.path))
if mime == 'application/octet-stream'
mime = Marcel::MimeType.for(extension: File.extname(value.path).delete_prefix('.')) || mime
end
data[key] = Faraday::FilePart.new(value.path, mime)
{{! SP-374: Marcel MIME fallback for unrecognized extensions (e.g. .json) - END }}
when ::Array, nil
# let Faraday handle Array and nil parameters
data[key] = value
Expand Down
Loading