[SP-374] Test JSON file upload for NFC face - #109
Open
dvacca-onfido wants to merge 1 commit into
Open
Conversation
Align the Ruby NFC face test with all other SDKs (Java, Python, PHP, Node) by actually uploading nfc_data.json instead of using a hardcoded document ID. This test is expected to fail (RED) due to Marcel failing to detect application/json MIME type for .json files, causing a 422 from the API. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dvacca-onfido
force-pushed
the
fix/test-json-file-upload
branch
from
August 24, 2026 13:47
344b442 to
c2a2564
Compare
DavidMealha-Onfido
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Aligns the Ruby NFC face test with all other SDKs (Java, Python, PHP, Node) by actually uploading
nfc_data.jsoninstead of using a hardcoded document ID.Expected result
This test is expected to fail (RED) because Marcel fails to detect
application/jsonMIME type for.jsonfiles, causing a 422 validation error from the API.The fix will follow in a separate PR updating the
api_client_faraday_partial.mustachetemplate inonfido-openapi-spec.