remove causal prefixes - #1501
Merged
Merged
Conversation
annadellisola
approved these changes
Aug 6, 2026
annadellisola
left a comment
annadellisola
left a comment
Contributor
There was a problem hiding this comment.
Thank you @lucasverleyen @qlambert-pro for addressing this issue.
I do agree with removing the causal prefix from the bus declaration. The causality is already expressed through the block boundary signals, while the bus itself acts as a shared structured connector.
LoneMeertens
approved these changes
Aug 7, 2026
LoneMeertens
left a comment
LoneMeertens
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Thanks for addressing this, @lucasverleyen and @qlambert-pro.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1500
@qlambert-pro fyi
@LoneMeertens @annadellisola When unit tests pass, this PR is ready for a final check by you.