Tune benchmark params to reduce variance#8308
Open
jack-berg wants to merge 2 commits intoopen-telemetry:mainfrom
Open
Tune benchmark params to reduce variance#8308jack-berg wants to merge 2 commits intoopen-telemetry:mainfrom
jack-berg wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8308 +/- ##
=========================================
Coverage 90.25% 90.25%
Complexity 7687 7687
=========================================
Files 850 850
Lines 23198 23198
Branches 2354 2354
=========================================
Hits 20938 20938
Misses 1532 1532
Partials 728 728 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Despite bare metal runners, the variance for the benchmarks we publish is unacceptably high, with CV's regularly well above 10% and sometimes exceeding 20%: https://open-telemetry.github.io/opentelemetry-java/benchmarks/
I've been doing some experimenting and unfortunately, it seems like in order to get the variance down, we need to increase the JMH forks, and iteration count. I tried to minimize the run time while keeping CV <5%, and landed on:
Runtime change:
@trask I know we run on shared hardware. Wondering if we can afford to reduce the variance without impacting other SIGs. If not, we could make up for the increased time by switching from running on every commit to main to running daily.