Skip to content

Tune benchmark params to reduce variance #8308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jack-berg merged 2 commits into from
Apr 23, 2026
+19 −19
Merged

Tune benchmark params to reduce variance #8308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4da3e71
Tune benchmark params to reduce variance
jack-berg Apr 20, 2026
2d48b13
cardinality 100 -> 128 for improved JIT modulo
jack-berg Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sdk/all/src/jmh/java/io/opentelemetry/sdk/LogRecordBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,9 @@ public void tearDown() {
@Benchmark
@Group("threads1")
@GroupThreads(1)
@Fork(1)
@Warmup(iterations = 5, time = 1)
@Measurement(iterations = 5, time = 1)
@Fork(3)
@Warmup(iterations = 3, time = 1)
@Measurement(iterations = 10, time = 1)
@OperationsPerInvocation(RECORDS_PER_INVOCATION)
public void record_SingleThread(BenchmarkState benchmarkState) {
record(benchmarkState);
Expand All @@ -123,9 +123,9 @@ public void record_SingleThread(BenchmarkState benchmarkState) {
@Benchmark
@Group("threads" + MAX_THREADS)
@GroupThreads(MAX_THREADS)
@Fork(1)
@Warmup(iterations = 5, time = 1)
@Measurement(iterations = 5, time = 1)
@Fork(3)
@Warmup(iterations = 3, time = 1)
@Measurement(iterations = 10, time = 1)
@OperationsPerInvocation(RECORDS_PER_INVOCATION)
public void record_MultipleThreads(BenchmarkState benchmarkState) {
record(benchmarkState);
Expand Down
14 changes: 7 additions & 7 deletions sdk/all/src/jmh/java/io/opentelemetry/sdk/MetricRecordBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public static class BenchmarkState {

@Param AggregationTemporality aggregationTemporality;

@Param({"1", "100"})
@Param({"1", "128"})
int cardinality;

// The following parameters are excluded from the benchmark to reduce combinatorial explosion
Expand Down Expand Up @@ -187,9 +187,9 @@ public void tearDown() {
@Benchmark
@Group("threads1")
@GroupThreads(1)
@Fork(1)
@Warmup(iterations = 5, time = 1)
@Measurement(iterations = 5, time = 1)
@Fork(3)
@Warmup(iterations = 3, time = 1)
@Measurement(iterations = 10, time = 1)
@OperationsPerInvocation(RECORDS_PER_INVOCATION)
public void record_SingleThread(BenchmarkState benchmarkState) {
record(benchmarkState);
Expand All @@ -198,9 +198,9 @@ public void record_SingleThread(BenchmarkState benchmarkState) {
@Benchmark
@Group("threads" + MAX_THREADS)
@GroupThreads(MAX_THREADS)
@Fork(1)
@Warmup(iterations = 5, time = 1)
@Measurement(iterations = 5, time = 1)
@Fork(3)
@Warmup(iterations = 3, time = 1)
@Measurement(iterations = 10, time = 1)
@OperationsPerInvocation(RECORDS_PER_INVOCATION)
public void record_MultipleThreads(BenchmarkState benchmarkState) {
record(benchmarkState);
Expand Down
12 changes: 6 additions & 6 deletions sdk/all/src/jmh/java/io/opentelemetry/sdk/SpanRecordBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,9 @@ public void tearDown() {
@Benchmark
@Group("threads1")
@GroupThreads(1)
@Fork(1)
@Warmup(iterations = 5, time = 1)
@Measurement(iterations = 5, time = 1)
@Fork(3)
@Warmup(iterations = 3, time = 1)
@Measurement(iterations = 10, time = 1)
@OperationsPerInvocation(RECORDS_PER_INVOCATION)
public void record_SingleThread(BenchmarkState benchmarkState) {
record(benchmarkState);
Expand All @@ -134,9 +134,9 @@ public void record_SingleThread(BenchmarkState benchmarkState) {
@Benchmark
@Group("threads" + MAX_THREADS)
@GroupThreads(MAX_THREADS)
@Fork(1)
@Warmup(iterations = 5, time = 1)
@Measurement(iterations = 5, time = 1)
@Fork(3)
@Warmup(iterations = 3, time = 1)
@Measurement(iterations = 10, time = 1)
@OperationsPerInvocation(RECORDS_PER_INVOCATION)
public void record_MultipleThreads(BenchmarkState benchmarkState) {
record(benchmarkState);
Expand Down
Loading