Repository navigation
fix(chart): render a digest-pinned image reference correctly - #40
Merged
Merged
Conversation
Renovate's docker:pinDigests appends a digest to image.tag. Pinning an empty tag produced "@sha256:...", which the template joined with ":" into ghcr.io/opendefensecloud/krop-controller:@sha256:... — not a valid reference, so a plain `helm install` of the published chart fails with ErrImagePull. Join with ":" only when there is a tag to join. All three shapes Renovate can leave behind now render: a tag, a tag with a digest, and a bare digest. Signed-off-by: Niklas Voss <niklas.voss@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate's docker:pinDigests appends a digest to image.tag. Pinning an empty tag produced "@sha256:...", which the template joined with ":" into ghcr.io/opendefensecloud/krop-controller:@sha256:... — not a valid reference, so a plain
helm installof the published chart fails with ErrImagePull.Join with ":" only when there is a tag to join. All three shapes Renovate can leave behind now render: a tag, a tag with a digest, and a bare digest.