Skip to content

fix(chart): render a digest-pinned image reference correctly #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trevex merged 2 commits into from
Sep 12, 2026
Merged

fix(chart): render a digest-pinned image reference correctly #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df458c9
fix(chart): render a digest-pinned image reference correctly
trevex Sep 12, 2026
0706494
Merge branch 'main' into chore/chart-image-digest-ref
trevex Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/krop-controller/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,12 @@ Controller image
*/}}
{{- define "krop-controller.image" -}}
{{- $tag := .Values.image.tag | default .Chart.AppVersion }}
{{- if hasPrefix "@" $tag }}
{{- printf "%s%s" .Values.image.repository $tag }}
{{- else }}
{{- printf "%s:%s" .Values.image.repository $tag }}
{{- end }}
{{- end }}

{{/*
Health probe / container port, derived from controller.healthProbeBindAddress
Expand Down
8 changes: 7 additions & 1 deletion charts/krop-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@
# -- Image configuration for krop-controller
image:
repository: ghcr.io/opendefensecloud/krop-controller
# -- Overrides the image tag (default is the chart appVersion)
# -- Overrides the image tag (default is the chart appVersion).
#
# Three shapes are accepted, because Renovate maintains this field and
# `docker:pinDigests` appends a digest to whatever is here: a tag ("v0.1.2"),
# a tag with a digest ("v0.1.2@sha256:..."), or a bare digest ("@sha256:..."),
# which is what pinning an empty tag produces. The template joins with ":"
# only when there is a tag to join.
tag: "@sha256:d14c6f54fa34f0f404f44d5dff13e11500e800bd449a50c8c552be9746a6d9a5"
pullPolicy: IfNotPresent

Expand Down
Loading