Skip to content

8384088: osThread _thread_id should be an int on all BSD's#31070

Open
snake66 wants to merge 2 commits into
openjdk:masterfrom
snake66:upstream-master--osthread-cleanup
Open

8384088: osThread _thread_id should be an int on all BSD's#31070
snake66 wants to merge 2 commits into
openjdk:masterfrom
snake66:upstream-master--osthread-cleanup

Conversation

@snake66
Copy link
Copy Markdown
Contributor

@snake66 snake66 commented May 7, 2026

The initializer for the _thread_id member in hotspot/os/bsd/osThread_bsd.cpp is incorrect for BSD's other than macOS. It should be an integer on all BSD's.

This work is sponsored by The FreeBSD Foundation



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8384088: osThread _thread_id should be an int on all BSD's (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31070/head:pull/31070
$ git checkout pull/31070

Update a local copy of the PR:
$ git checkout pull/31070
$ git pull https://git.openjdk.org/jdk.git pull/31070/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31070

View PR using the GUI difftool:
$ git pr show -t 31070

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31070.diff

Using Webrev

Link to Webrev Comment

The initializer for the _thread_id member in
hotspot/os/bsd/osThread_bsd.cpp is incorrect for BSD's other than macOS.
It should be an integer on all BSD's.

This work is sponsored by The FreeBSD Foundation
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 7, 2026

👋 Welcome back haraldei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 7, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 7, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 7, 2026

@snake66 The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 7, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-runtime. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 7, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 7, 2026

Webrevs

Copy link
Copy Markdown
Member

@Arraying Arraying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, pid_t is actually __pid_t which is an __int32_t on FreeBSD. I checked OpenBSD and NetBSD as well (these are the ones we have macros for) and it's the same there. Seems like a reasonable change to me, thank you!

Comment thread src/hotspot/os/bsd/osThread_bsd.cpp Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump.

This work is sponsored by The FreeBSD Foundation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants