8384088: osThread _thread_id should be an int on all BSD's#31070
8384088: osThread _thread_id should be an int on all BSD's#31070snake66 wants to merge 2 commits into
Conversation
The initializer for the _thread_id member in hotspot/os/bsd/osThread_bsd.cpp is incorrect for BSD's other than macOS. It should be an integer on all BSD's. This work is sponsored by The FreeBSD Foundation
|
👋 Welcome back haraldei! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
Webrevs
|
Arraying
left a comment
There was a problem hiding this comment.
IIUC, pid_t is actually __pid_t which is an __int32_t on FreeBSD. I checked OpenBSD and NetBSD as well (these are the ones we have macros for) and it's the same there. Seems like a reasonable change to me, thank you!
This work is sponsored by The FreeBSD Foundation
The initializer for the _thread_id member in hotspot/os/bsd/osThread_bsd.cpp is incorrect for BSD's other than macOS. It should be an integer on all BSD's.
This work is sponsored by The FreeBSD Foundation
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31070/head:pull/31070$ git checkout pull/31070Update a local copy of the PR:
$ git checkout pull/31070$ git pull https://git.openjdk.org/jdk.git pull/31070/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31070View PR using the GUI difftool:
$ git pr show -t 31070Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31070.diff
Using Webrev
Link to Webrev Comment