Skip to content

8384088: osThread _thread_id should be an int on all BSD's #31070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snake66 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

8384088: osThread _thread_id should be an int on all BSD's #31070

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
168a1a1
8384088: osThread _thread_id should be an int on all BSD's
snake66 May 7, 2026
226aa1a
Update copyright year
snake66 May 11, 2026
d0d84a3
Putting signal.h back in where it should be
snake66 May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/hotspot/os/bsd/osThread_bsd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 1999, 2025, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1999, 2026, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -29,13 +29,7 @@
#include <signal.h>
Copy link
Copy Markdown
Member

@dholmes-ora dholmes-ora May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this?

Copy link
Copy Markdown
Contributor Author

@snake66 snake66 May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see it being used by the code.

Copy link
Copy Markdown
Member

@dholmes-ora dholmes-ora May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 40: sigemptyset(&_caller_sigmask);

Copy link
Copy Markdown
Contributor Author

@snake66 snake66 May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man! How could I miss that!
I'll put it back in :)


OSThread::OSThread()
: _thread_id(
#ifdef __APPLE__
0
#else
nullptr
#endif
),
: _thread_id(0),
_pthread_id(nullptr),
_unique_thread_id(0),
_caller_sigmask(),
Expand Down