[release-4.19] OCPBUGS-82814,OCPBUGS-82786: Address CVE-2026-35469

[rissh]

Summary

Bump github.com/moby/spdystream from v0.5.0 to v0.5.1 on release-4.19 to address CVE-2026-35469 (SPDY frame parsing DoS).

Upstream fix: kubernetes/kubernetes#138358

Advisory: GHSA-pc3f-x583-g7j2

Problem

github.com/moby/spdystream ≤ v0.5.0 does not validate attacker-controlled counts/lengths in SPDY/3 control frames before allocation. A remote peer that can send SPDY frames can trigger memory exhaustion (OOM) via crafted SETTINGS/header frames.

Kubernetes uses spdystream via k8s.io/apimachinery/pkg/util/httpstream/spdy for kubelet streaming (exec/attach/portforward) and kube-apiserver→kubelet SPDY proxy paths.

Solution

Vendor bump to v0.5.1, which adds bounds checks on SETTINGS entry count, header count, and header field sizes.

Changes

• go.mod / go.sum: github.com/moby/spdystream v0.5.1
• vendor/github.com/moby/spdystream/: updated to v0.5.1 (includes new spdy/options.go, LICENSE/PATENTS)
• Staging module go.mod / go.sum files updated via hack/update-vendor.sh

Verification

• go.mod pins github.com/moby/spdystream v0.5.1
• Vendor contains v0.5.1 fix (e.g. numSettings validation in vendor/github.com/moby/spdystream/spdy/read.go)
• hack/pin-dependency.sh + hack/update-vendor.sh run in rhel-9-golang-1.23-openshift-4.19 builder

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 97a25cf6-f984-4582-a63d-b2c1d912d020

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@rissh: the contents of this pull request could be automatically validated.

The following commits are valid:

• a95a1c9|UPSTREAM: 138358: Update github.com/moby/spdystream from v0.5.0 to v0.5.1 for CVE-2026-35469: the upstream PR kubernetes/kubernetes#138358 has merged

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[rissh]

/retest

[openshift-ci]

@rissh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jubittajohn]

/lgtm
/label backport-risk-assessed
/approved

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jubittajohn, rissh
Once this PR has been reviewed and has the lgtm label, please assign jerpeter1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jubittajohn]

/jira refresh

[openshift-ci-robot]

@jubittajohn: This pull request references Jira Issue OCPBUGS-82814, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.z) matches configured target version for branch (4.19.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-82861 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-82861 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rissh]

/retitle [release-4.19] OCPBUGS-82814,OCPBUGS-82786: Address CVE-2026-35469

[openshift-ci-robot]

@rissh: This pull request references Jira Issue OCPBUGS-82814, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.z) matches configured target version for branch (4.19.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-82861 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-82861 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-82786, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-82786 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Bump github.com/moby/spdystream from v0.5.0 to v0.5.1 on release-4.19 to address CVE-2026-35469 (SPDY frame parsing DoS).

Upstream fix: kubernetes/kubernetes#138358

Advisory: GHSA-pc3f-x583-g7j2

Problem

github.com/moby/spdystream ≤ v0.5.0 does not validate attacker-controlled counts/lengths in SPDY/3 control frames before allocation. A remote peer that can send SPDY frames can trigger memory exhaustion (OOM) via crafted SETTINGS/header frames.

Kubernetes uses spdystream via k8s.io/apimachinery/pkg/util/httpstream/spdy for kubelet streaming (exec/attach/portforward) and kube-apiserver→kubelet SPDY proxy paths.

Solution

Vendor bump to v0.5.1, which adds bounds checks on SETTINGS entry count, header count, and header field sizes.

Changes

• go.mod / go.sum: github.com/moby/spdystream v0.5.1
• vendor/github.com/moby/spdystream/: updated to v0.5.1 (includes new spdy/options.go, LICENSE/PATENTS)
• Staging module go.mod / go.sum files updated via hack/update-vendor.sh

Verification

• go.mod pins github.com/moby/spdystream v0.5.1
• Vendor contains v0.5.1 fix (e.g. numSettings validation in vendor/github.com/moby/spdystream/spdy/read.go)
• hack/pin-dependency.sh + hack/update-vendor.sh run in rhel-9-golang-1.23-openshift-4.19 builder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[germanparente]

skipping dependent bug check since this is already fixed in 4.20 branch:

ref: https://github.com/openshift/kubernetes/blob/release-4.20/go.mod#L190

/label jira/skip-dependent-bug-check

[openshift-ci-robot]

@rissh: This pull request references Jira Issue OCPBUGS-82814, which is valid.

4 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.z) matches configured target version for branch (4.19.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

This pull request references Jira Issue OCPBUGS-82786, which is valid. The bug has been moved to the POST state.

4 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.z) matches configured target version for branch (4.19.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

Details

In response to this:

Summary

Bump github.com/moby/spdystream from v0.5.0 to v0.5.1 on release-4.19 to address CVE-2026-35469 (SPDY frame parsing DoS).

Upstream fix: kubernetes/kubernetes#138358

Advisory: GHSA-pc3f-x583-g7j2

Problem

github.com/moby/spdystream ≤ v0.5.0 does not validate attacker-controlled counts/lengths in SPDY/3 control frames before allocation. A remote peer that can send SPDY frames can trigger memory exhaustion (OOM) via crafted SETTINGS/header frames.

Kubernetes uses spdystream via k8s.io/apimachinery/pkg/util/httpstream/spdy for kubelet streaming (exec/attach/portforward) and kube-apiserver→kubelet SPDY proxy paths.

Solution

Vendor bump to v0.5.1, which adds bounds checks on SETTINGS entry count, header count, and header field sizes.

Changes

• go.mod / go.sum: github.com/moby/spdystream v0.5.1
• vendor/github.com/moby/spdystream/: updated to v0.5.1 (includes new spdy/options.go, LICENSE/PATENTS)
• Staging module go.mod / go.sum files updated via hack/update-vendor.sh

Verification

• go.mod pins github.com/moby/spdystream v0.5.1
• Vendor contains v0.5.1 fix (e.g. numSettings validation in vendor/github.com/moby/spdystream/spdy/read.go)
• hack/pin-dependency.sh + hack/update-vendor.sh run in rhel-9-golang-1.23-openshift-4.19 builder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.