[OCISDEV-843] Flaky search test - 2nd fix#13800
Open
deyankiteworks wants to merge 3 commits into
Open
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
deyankiteworks
force-pushed
the
fix/OCISDEV-843-fix
branch
from
90bdfab to
6fed9cd
Compare
mzner
reviewed
May 20, 2026
| await ui.userShouldSeeResources({ | ||
| world, | ||
| listType: resourcePage.searchList, | ||
| listType: resourcePage.filesList, |
Contributor
There was a problem hiding this comment.
@deyankiteworks Are we sure we want to use filesList instead of searchList? Why was it passing before then?
Member
Author
There was a problem hiding this comment.
You're correct. We need to keep resourcePage.searchList as the correct listType.
Member
Author
There was a problem hiding this comment.
@mzner I had to change the whole E2E test. Will wait for @nirajacharya2 to take a look at it.
|
Comment on lines
-279
to
-280
| // And "Alice" enables the option to search title only | ||
| await ui.userEnablesTitleOnlySearch({ world, stepUser: 'Alice' }) |
Contributor
There was a problem hiding this comment.
why was this removed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resourcePage.filesListinstead ofresourcePage.searchListfor asserting search results after pressing EnterResourceTablewith[data-test-resource-path]selectors — NOT the dropdown (#files-global-search-options)waitForTimeoutworkaround from the first fix attemptRelated Issue
Test plan
🤖 Generated with Claude Code