Skip to content

[OCISDEV-843] Flaky search test - 2nd fix #13800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deyankiteworks wants to merge 3 commits into
base: master
Choose a base branch
from
+11 −9
Open

[OCISDEV-843] Flaky search test - 2nd fix #13800

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fed9cd
fix(e2e): [OCISDEV-843] Use correct listType for search results after…
deyankiteworks May 20, 2026
768896a
fix(e2e): [OCISDEV-843] Keeps resourcePage.searchList as the correct …
deyankiteworks May 21, 2026
8aabee1
fix(e2e): [OCISDEV-843] Reworked the e2e test for search difficult names
deyankiteworks May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions tests/e2e/specs/search/search.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,9 +265,6 @@ test.describe('Search', { tag: '@predefined-users' }, () => {
})

// # search difficult names
// allow extra time for search indexing of Unicode folder name after rename operations
const { page } = world.actorsEnvironment.getActor({ key: 'Alice' })
await page.waitForTimeout(2000)
// When "Alice" searches "strängéनेपालीName" using the global search and the "all files" filter and presses enter
await ui.userSearchesGloballyWithFilter({
world,
Expand All @@ -282,7 +279,7 @@ test.describe('Search', { tag: '@predefined-users' }, () => {
// | strängéनेपालीName |
await ui.userShouldSeeResources({
world,
listType: resourcePage.searchList,
listType: resourcePage.filesList,
Copy link
Copy Markdown
Contributor

@mzner mzner May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deyankiteworks Are we sure we want to use filesList instead of searchList? Why was it passing before then?

Copy link
Copy Markdown
Member Author

@deyankiteworks deyankiteworks May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct. We need to keep resourcePage.searchList as the correct listType.

Copy link
Copy Markdown
Member Author

@deyankiteworks deyankiteworks May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzner I had to change the whole E2E test. Will wait for @nirajacharya2 to take a look at it.

stepUser: 'Alice',
resources: ['strängéनेपालीName']
})
Expand Down
Loading