Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/e2e.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ export default createE2EConfig([
{ file: 'lexical__collections__Lexical__e2e__main', shards: 2 },
{ file: 'lexical__collections__Lexical__e2e__blocks', shards: 2 },
{ file: 'lexical__collections__Lexical__e2e__blocks#config.blockreferences.ts', shards: 2 },
{ file: 'lexical__collections__RichText', shards: 1 },
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one only had a single test remaining that used this deprecated HTMLConverterFeature

{ file: 'query-presets', shards: 1 },
{ file: 'form-state', shards: 1 },
{ file: 'live-preview', shards: 2 },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { QuoteNode } from '@lexical/rich-text'
import type { StronglyTypedElementNode } from '../../../nodeTypes.js'

import { createServerFeature } from '../../../utilities/createServerFeature.js'
import { convertLexicalNodesToHTML } from '../../converters/lexicalToHtml_deprecated/converter/index.js'
import { createNode } from '../../typeUtilities.js'
import { MarkdownTransformer } from '../markdownTransformer.js'
import { i18n } from './i18n.js'
Expand All @@ -22,49 +21,6 @@ export const BlockquoteFeature = createServerFeature({
markdownTransformers: [MarkdownTransformer],
nodes: [
createNode({
converters: {
html: {
converter: async ({
converters,
currentDepth,
depth,
draft,
node,
overrideAccess,
parent,
req,
showHiddenFields,
}) => {
const childrenText = await convertLexicalNodesToHTML({
converters,
currentDepth,
depth,
draft,
lexicalNodes: node.children,
overrideAccess,
parent: {
...node,
parent,
},
req,
showHiddenFields,
})
const style = [
node.format ? `text-align: ${node.format};` : '',
// the unit should be px. Do not change it to rem, em, or something else.
// The quantity should be 40px. Do not change it either.
// See rationale in
// https://github.com/payloadcms/payload/issues/13130#issuecomment-3058348085
node.indent > 0 ? `padding-inline-start: ${node.indent * 40}px;` : '',
]
.filter(Boolean)
.join(' ')

return `<blockquote${style ? ` style='${style}'` : ''}>${childrenText}</blockquote>`
},
nodeTypes: [QuoteNode.getType()],
},
},
node: QuoteNode,
}),
],
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading